Default to python when uv run does not recieve a command
#3109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
added
internal
zanieb
force-pushed
the
zb/uv-run-python
branch
from
e5f0c32 to
db9246f
Compare
zanieb
commented
Apr 17, 2024
| args: Vec<String>, | ||
| mut requirements: Vec<RequirementsSource>, | ||
| isolated: bool, | ||
| no_workspace: bool, | ||
| cache: &Cache, | ||
| printer: Printer, | ||
| ) -> Result<ExitStatus> { | ||
| let command = target.unwrap_or("python".to_string()); |
There was a problem hiding this comment.
I guess we could use the direct path to the Python in the virtual environment but that seems overkill to me?
|
The alternative is adding a |
konstin
approved these changes
Apr 18, 2024
zanieb
force-pushed
the
zb/uv-run-no-workspace
branch
from
a7c53f1 to
501719e
Compare
zanieb
force-pushed
the
zb/uv-run-python
branch
from
db9246f to
6f82f21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means that a bare
uv runinvocation drops you into a REPL.This behavior is internally controversial, and may best be served by a dedicated
uv replcommand. I would imagine it's important to fail if no command is given in some circumstances, but those may be resolved by not doing this if we do not detect a TTY.Regardless, I'm interested in giving this a try for a bit during this experimental phase.