Expand Windows shim detection to include python3.12.exe
#2209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
added
bug
charliermarsh
commented
Mar 5, 2024
| /// | ||
| /// Matches against paths like: | ||
| /// `C:\Users\crmar\AppData\Local\Microsoft\WindowsApps\python.exe` | ||
| pub(super) fn is_windows_store_shim(path: &Path) -> bool { |
There was a problem hiding this comment.
I structured this to look similar to is_windows_store_python.
charliermarsh
force-pushed
the
charlie/win
branch
2 times, most recently
from
e4c2652
to
a64c94a
Compare
charliermarsh
force-pushed
the
charlie/win
branch
from
a64c94a
to
ef373fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Our Windows shim detection wasn't catching shims like
python3.12.exe.Closes #2208.
Test Plan
Installed Python 3.12 via the Windows Store; verified that
cargo run venv --python 3.12failed before but passes after this change.