Allow empty extras in pep508-rs and add more corner case to tests
#2128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SigureMo
changed the title
SigureMo
changed the title
pep508-rs and add more corner case to tests
AlexWaygood
reviewed
Mar 2, 2024
Co-authored-by: Alex Waygood <[email protected]>
charliermarsh
added
bug
charliermarsh
force-pushed
the
pep508-allow-empty-extras
branch
from
5e0151f
to
646cdbd
Compare
| @@ -617,9 +617,48 @@ fn parse_extras(cursor: &mut Cursor) -> Result<Vec<ExtraName>, Pep508Error> { | |||
| let Some(bracket_pos) = cursor.eat_char('[') else { | |||
| return Ok(vec![]); | |||
| }; | |||
| cursor.eat_whitespace(); | |||
There was a problem hiding this comment.
Moved this out from the start of the loop, because it's also at the end of the loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2127, allow empty extras, and add more corner case to tests
References