virtualenv: determine 'site-packages' based on implementation name #2094
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not at all sure whether this is a correct fix or not, but it does
seem to make
pypy
work in at least some cases withuv
. Previously,I couldn't get it to work at all. Namely the virtualenv was created
with a
lib/python3.10/site-packages
, but whenever I did auv pip install
in that virtualenv, it was looking for a non-existentlib/pypy3.10/site-packages
directory.With this PR, the workflow reported as not working in #1488 now works
for me:
Where as previously (current
main
), I was hitting this error:Notice though that neither outcome above matches the error reported in #1488,
so this is likely not a complete fix. There are perhaps other lurking
issues.
Ref #1488