Add a --system flag for opt-in non-virtualenv installs
#2046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
added
enhancement
charliermarsh
force-pushed
the
charlie/system
branch
6 times, most recently
from
62796c9
to
b18f393
Compare
zanieb
approved these changes
Feb 28, 2024
AlexWaygood
reviewed
Feb 28, 2024
zanieb
reviewed
Feb 28, 2024
|
@zanieb - Do you want me to check-in the testing (perhaps making it |
charliermarsh
force-pushed
the
charlie/system
branch
4 times, most recently
from
77e274c
to
706108c
Compare
|
@charliermarsh I can take ownership of productionizing them from wherever you want to leave it — workflow dispatch seems fine |
charliermarsh
force-pushed
the
charlie/system
branch
3 times, most recently
from
2942e40
to
24d3eaf
Compare
charliermarsh
force-pushed
the
charlie/system
branch
3 times, most recently
from
6b40ac0
to
7881b04
Compare
AlexWaygood
reviewed
Feb 28, 2024
| run: cargo build | ||
|
|
||
| - name: "Print Python path" | ||
| run: echo $(which python) |
There was a problem hiding this comment.
I don't think Windows has an echo command or a which command
There was a problem hiding this comment.
It turns out that it doesn't matter on GHA:
charliermarsh
force-pushed
the
charlie/system
branch
5 times, most recently
from
01a6dd5
to
778c1a2
Compare
charliermarsh
force-pushed
the
charlie/system
branch
4 times, most recently
from
82c4c91
to
fa3f6ee
Compare
charliermarsh
force-pushed
the
charlie/system
branch
from
fa3f6ee
to
0c946d6
Compare
|
🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is essentially a wrapper around something like
--python $(which python3), but gives users a portable and streamlined way to solve the common pain point of usinguvin GitHub Actions or a Docker container.See: #1526.