Enable freeze and list to introspect non-virtualenv Pythons
#2033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
changed the title
freeze and list to enumerate default Python installsfreeze and list to introspect non-virtualenv Pythons
charliermarsh
added
the
compatibility
charliermarsh
commented
Feb 28, 2024
| match Virtualenv::from_env(platform.clone(), cache) { | ||
| Ok(venv) => venv, | ||
| Err(uv_interpreter::Error::VenvNotFound) => { | ||
| Virtualenv::from_default_python(&platform, cache)? |
There was a problem hiding this comment.
This does mean that if a virtualenv doesn't exist, we "silently" fall back to the default Python; and you'll never see the "No virtualenv exists" error, only the error you might get if the fallback fails.
It kind of makes me want to change this to user-facing logging?
debug!(
"Using Python {} environment at {}",
venv.interpreter().python_version(),
venv.python_executable().normalized_display().cyan()
);
konstin
approved these changes
Feb 28, 2024
| match Virtualenv::from_env(platform.clone(), cache) { | ||
| Ok(venv) => venv, | ||
| Err(uv_interpreter::Error::VenvNotFound) => { | ||
| Virtualenv::from_default_python(&platform, cache)? |
crates/uv/src/main.rs
Outdated
| /// The Python interpreter for which packages should be listed. | ||
| /// | ||
| /// By default, `uv` lists packages in the currently activated virtual environment, or an | ||
| /// environment located in the current working directory or any parent directory, falling back |
There was a problem hiding this comment.
Suggested change
| /// environment located in the current working directory or any parent directory, falling back | |
| /// environment `.venv` located in the current working directory or any parent directory, falling back |
| /// | ||
| /// Supported formats: | ||
| /// - `3.10` looks for an installed Python 3.10 using `py --list-paths` on Windows, or | ||
| /// `python3.10` on Linux and macOS. (Specifying a patch version is not supported.) |
charliermarsh
force-pushed
the
charlie/freeze
branch
from
9109caf
to
ce52146
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Now that we have the ability to introspect the installed packages for arbitrary Pythons, we can allow
pip freezeandpip listto fall back to the "default" Python, if no virtualenv is present.Closes #2005.