fix 'pip install' for zips with bunk permissions #1757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BurntSushi
force-pushed
the
ag/fix-1453
branch
from
0b5128d
to
c23b836
Compare
|
This fix is actually duplicative with #1743, which also fixes #1453 (but in a better way). So I removed the "fix" from this PR, but kept the regression test and a couple other small fixups. Once #1743 is merged, we should be able to bring this one in. (CI for this branch will fail on the regression test until then.) |
A WARN log was being emitted for a "broken cache entry" in the case where the cache entry simply doesn't exist. But this is totally fine and expected. So we detect the kind of error that occurred and emit a TRACE if the file simply didn't exist.
This is just a style thing.
This ensures we can install a source dist from a `zip` file that has present but bunk permissions. Fixes #1453
BurntSushi
force-pushed
the
ag/fix-1453
branch
from
c23b836
to
055453d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where installing a source dist from a
zipfile couldfail if the permissions in the
zipfile were bunk. Namely, after extractinga
zipfile, we go through each record and set the permissions on each filebased on the permissions recorded in the
zipfile. But apparently, thosepermissions are sometimes present but
0, which in turn caused us to set thepermissions to
0on files and thus prevent our access to them.We fix this by treating "absent permissions" and "permissions of mode 0" as the
same thing.
Fixes #1453