Preserve trailing slash for --find-links URLs
#1720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We should allow a
--find-linksURL to be provided as either (e.g.)https://wheelhouse.acsone.eu/manylinux1orhttps://wheelhouse.acsone.eu/manylinux1/. By using the response URL, we can "always do the right thing" (it will always have a trailing slash, or always return a.htmlsuffix) rather than attempting to sniff out the URL kind in advance.Closes #1683.
Test Plan
cargo run pip install requests --force-reinstall --no-index --find-links https://wheelhouse.acsone.eu/manylinux1 -ncargo run pip install requests --force-reinstall --no-index --find-links https://wheelhouse.acsone.eu/manylinux1/ -n