Consistent use of BIN_NAME
in activation scripts
#1577
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the bug where the
BIN_NAME
replacement field wasn't being used in the activator scripts.fixes: #1518
Test plan
As I don't have a Windows machine, I switched the
bin_name
value here to point toScripts
onunix
platform:uv/crates/gourgeist/src/bare.rs
Lines 99 to 105 in 2a76c59
Code diff
I then created the virtual environment as usual and tested out that the path modifications were correct:
I'm not sure how else to test this without having access to a Windows machine