Add support for extras in editable requirements #1531
Conversation
charliermarsh
force-pushed
the
charlie/editable
branch
2 times, most recently
from
c43865b to
8871bc2
Compare
| // Mock editable responses. | ||
| let package_id = dist.package_id(); | ||
| index.distributions.register(package_id.clone()); | ||
| index.distributions.done(package_id, metadata.clone()); |
There was a problem hiding this comment.
I think removing this is good.
| @@ -633,6 +625,16 @@ impl<'a, Provider: ResolverProvider> Resolver<'a, Provider> { | |||
| } | |||
|
|
|||
| PubGrubPackage::Package(package_name, extra, None) => { | |||
| // If the dist is an editable, return the version from the editable metadata. | |||
| if let Some((_local, metadata)) = self.editables.get(package_name) { | |||
There was a problem hiding this comment.
The only downside to all of this is that we now pay the cost of doing these lookups for all packages.
charliermarsh
force-pushed
the
charlie/editable
branch
from
8871bc2 to
173fd21
Compare
|
Ah, thank you very much for this! I was just about to report it given . :) (Go Astral team go! 🚀 ⭐) |
|
@charliermarsh @zanieb we're still seeing this in https://github.com/scikit-hep/pyhf when we try to do $ uv --version
uv 0.1.4
$ python -m uv pip install --upgrade ".[all,test]"
error: Failed to parse `.[all,test]`
Caused by: Expected package name starting with an alphanumeric character, found '.'
.[all,test]
^
$ |
|
That’s a slightly different issue — you can either use -e (like -e “.[all,test]”) or provide a package name like “pyhf @ .[all,test]”. We have a limitation that we require package names upfront for non-editable requirements, but we’ll be lifting that in the future. |
|
Ah okay great. I was alreadying watching Issue #313 but for some reason hadn't made the connection. Thanks! |
Summary
If you're developing on a package like
attrslocally, and it has a recursive extra likeattrs[dev], it turns out that we then try to find theattrsinattrs[dev]from the registry, rather than recognizing that it's part of the editable.This PR fixes the issue by making editables slightly more first-class throughout the resolver. Instead of mocking metadata, we explicitly check for extras in various places. Part of the problem here is that we treated editables as URL dependencies, but when we saw an extra like
attrs[dev], we didn't map that back to the URL. So now, we treat them as registry dependencies, but with the appropriate guardrails throughout.Closes #1447.
Test Plan
attrs.cargo run venv && cargo run pip install -e ".[dev]" -v.