Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of our test drive in Windows CI #10651

Merged
merged 3 commits into from
Jan 16, 2025
Merged

Conversation

zanieb
Copy link
Member

@zanieb zanieb commented Jan 15, 2025

Previously, we couldn't use a DevDrive (#3522 (comment)) because our Windows version was not sufficient.

Recently, I upgraded our larger runners to Windows 2025 preview (#10298) which I presume has support for this.

I removed ReFS in 953c353 which didn't seem to do anything to performance.

I also found some notes on "trusted" DevDrives and "disabling anti-virus filtering" which I simply have to try.

@zanieb zanieb added testing Internal testing of behavior internal A refactor or improvement that is not user-facing labels Jan 15, 2025
@zanieb zanieb force-pushed the zb/dev-filters branch 5 times, most recently from 88a9e48 to 01ea47a Compare January 15, 2025 22:08
@zanieb zanieb changed the title Disable all file-system filtering on the CI Dev Drive Improve performance of our test drive in Windows CI Jan 15, 2025
@zanieb
Copy link
Member Author

zanieb commented Jan 15, 2025

Sadly I see no change, even though these are taking effect correctly (from the debug log).

@zanieb
Copy link
Member Author

zanieb commented Jan 16, 2025

Maybe this has a minor performance improvement. It's more visible in #10662

I think this might get us more consistency / seems fine to merge regardless of a lack of clear improvement.

@zanieb zanieb marked this pull request as ready for review January 16, 2025 17:41
@zanieb zanieb requested a review from samypr100 January 16, 2025 17:41
@zanieb zanieb temporarily deployed to uv-test-publish January 16, 2025 17:45 — with GitHub Actions Inactive
@zanieb zanieb merged commit 75a1a47 into main Jan 16, 2025
64 checks passed
@zanieb zanieb deleted the zb/dev-filters branch January 16, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal A refactor or improvement that is not user-facing testing Internal testing of behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants