Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uv remove should remove tool.uv.sources entries if it's the only reference #8330

Closed
zanieb opened this issue Oct 18, 2024 · 2 comments · Fixed by #8359
Closed

uv remove should remove tool.uv.sources entries if it's the only reference #8330

zanieb opened this issue Oct 18, 2024 · 2 comments · Fixed by #8359
Labels
bug Something isn't working help wanted Contribution especially encouraged

Comments

@zanieb
Copy link
Member

zanieb commented Oct 18, 2024

e.g. as described in #8328 (comment)
@zanieb zanieb added cli Related to the command line interface bug Something isn't working and removed cli Related to the command line interface labels Oct 18, 2024
@charliermarsh
Copy link
Member

Oh nice.

@charliermarsh charliermarsh added the help wanted Contribution especially encouraged label Oct 18, 2024
@cgravill cgravill mentioned this issue Oct 18, 2024
Closed
@j178
Copy link
Contributor

j178 commented Oct 19, 2024

uv remove actually removes entries from tool.uv.sources:

uv/crates/uv-workspace/src/pyproject_mut.rs

Line 455 in 4b0a4da

self.remove_source(name)?;

The issue in #8328 (comment) is that the key in tool.uv.sources is example_python_library, but the package name is normalized to example-python-library, so the source is not removed. I think we need to normalize keys in tool.uv.sources before comparison.

@j178 j178 mentioned this issue Oct 19, 2024
Merged
@zanieb zanieb closed this as completed in ac451af Oct 19, 2024
j178 added a commit to j178/uv that referenced this issue Oct 19, 2024
@j178
Check existing source by normalized name before add and remove (astra…
605a805 
…l-sh#8359)

Resolves astral-sh#8328
Resolves astral-sh#8330
MtkN1 pushed a commit to MtkN1/uv that referenced this issue Oct 21, 2024
@j178 @MtkN1
Check existing source by normalized name before add and remove (astra…
8b8bded 
…l-sh#8359)

Resolves astral-sh#8328
Resolves astral-sh#8330
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Contribution especially encouraged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check existing source by normalized name before add and remove j178/uv
3 participants
@charliermarsh @zanieb @j178