Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PEP 508-style editable requirements #3941

Closed
charliermarsh opened this issue May 31, 2024 · 0 comments · Fixed by #3946
Closed

Support PEP 508-style editable requirements #3941

charliermarsh opened this issue May 31, 2024 · 0 comments · Fixed by #3946
Assignees
Labels
enhancement New feature or improvement to existing functionality

Comments

@charliermarsh
Copy link
Member

For example, --editable "mypkg[dist] @ git+https://github.com/username/mypkg" is supposed to work. That it doesn't work in pip right now is an implementation limitation. See: pypa/pip#1289.

@charliermarsh charliermarsh added the enhancement New feature or improvement to existing functionality label May 31, 2024
@charliermarsh charliermarsh self-assigned this May 31, 2024
charliermarsh added a commit that referenced this issue May 31, 2024
## Summary

This will help prevent bugs like #3934 by unifying the implementations
for editables and non-editable unnamed requirements. Specifically, both
of these now go through the same parsing paths and use the same struct
representations (with the exception that the editable flag is flipped in
the first case):

```
-e ./foo/bar
./foo/bar
```

We also now support PEP 508 in editable URLs. It turns out this is just
a limitation in pip, so it's correct to support it. For example, this
now works:

```
-e black[d] @ file://${PROJECT_ROOT}/scripts/packages/black_editable
```

Closes #3941.

Closes #3942.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvement to existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant