Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning when poetry dependencies found instead of PEP 621 dependencies #1630

Closed
zanieb opened this issue Feb 18, 2024 · 0 comments · Fixed by #1650
Closed

Add warning when poetry dependencies found instead of PEP 621 dependencies #1630

zanieb opened this issue Feb 18, 2024 · 0 comments · Fixed by #1650
Labels
error messages Messaging when something goes wrong good first issue Good for newcomers

Comments

@zanieb
Copy link
Member

zanieb commented Feb 18, 2024

This results in an empty lock file and has caused some confusion:

We can detect this case and warn.
@zanieb zanieb added error messages Messaging when something goes wrong good first issue Good for newcomers labels Feb 18, 2024
@zanieb zanieb mentioned this issue Feb 18, 2024
Closed
@yasufumy yasufumy mentioned this issue Feb 18, 2024
Merged
This was referenced Feb 19, 2024
Closed
Closed
charliermarsh pushed a commit that referenced this issue Feb 20, 2024
@yasufumy
Add warning when dependencies are empty with Poetry metadata (#1650)
8f739c9 
Resolve #1630 

`PyProjectToml` doesn't seem to have a `tool` field, so instead of
checking it, I check if `requirements` is empty.


https://github.com/astral-sh/uv/blob/c04f597fae7a04be6124d91a9b77f211941f3cd6/crates/uv-build/src/lib.rs#L176-L184
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
error messages Messaging when something goes wrong good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add warning when dependencies are empty with Poetry metadata yasufumy/uv
1 participant
@zanieb