Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seeding venv adds setuptools and wheel on Python 3.12 #1602

Closed
henryiii opened this issue Feb 17, 2024 · 2 comments · Fixed by #1613
Closed

Seeding venv adds setuptools and wheel on Python 3.12 #1602

henryiii opened this issue Feb 17, 2024 · 2 comments · Fixed by #1613
Labels
compatibility Compatibility with a specification or another tool good first issue Good for newcomers performance Potential performance improvement

Comments

@henryiii
Copy link
Contributor

henryiii commented Feb 17, 2024 •
edited
Loading

If you use --seed on a Python 3.12 venv, you still get setuptools and wheel, while both virutalenv and venv have dropped them if using Python 3.12 or newer. This causes uv venv -p 3.12 --seed (524ms) to be slower than virtualenv .venv (360ms), which is only adding pip.
@zanieb
Copy link
Member

zanieb commented Feb 17, 2024

Thanks! We can drop them too.

@zanieb zanieb added good first issue Good for newcomers compatibility Compatibility with a specification or another tool labels Feb 17, 2024
@AlexWaygood AlexWaygood added the performance Potential performance improvement label Feb 17, 2024
@charliermarsh
Copy link
Member

Oh wow!

arjunnn added a commit to arjunnn/uv that referenced this issue Feb 17, 2024
@arjunnn
Remove setuptools & wheel from seed packages (astral-sh#1602)
9ab19d6
arjunnn added a commit to arjunnn/uv that referenced this issue Feb 17, 2024
@arjunnn
Remove setuptools & wheel from seed packages (astral-sh#1602)
b8d0314
@zanieb zanieb mentioned this issue Feb 17, 2024
Merged
zanieb added a commit that referenced this issue Feb 18, 2024
@arjunnn @zanieb
Remove setuptools & wheel from seed packages (#1602) (#1613)
3ed386c 
## Summary
Removed `wheel` and `setuptools` from seed packages list when creating a
virtual environment

Closes #1602

## Test Plan
Ran the command `cargo nextest run` :
<img width="564" alt="image"
src="https://github.com/astral-sh/uv/assets/6116387/14ed2da6-1b3e-4598-a49f-29dd8c4cb19b">

---------

Co-authored-by: Zanie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compatibility Compatibility with a specification or another tool good first issue Good for newcomers performance Potential performance improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove setuptools & wheel from seed packages (#1602) arjunnn/uv
4 participants
@charliermarsh @zanieb @henryiii @AlexWaygood