Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add acknowledgements and Astral logo #34

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Add acknowledgements and Astral logo #34

merged 1 commit into from
Sep 4, 2024

Conversation

charliermarsh
Copy link
Member

No description provided.

@charliermarsh charliermarsh force-pushed the charlie/ack branch 2 times, most recently from 2266ee3 to 1b50566 Compare September 4, 2024 20:53
@charliermarsh charliermarsh added the documentation Improvements or additions to documentation label Sep 4, 2024
@charliermarsh charliermarsh requested a review from zanieb September 4, 2024 20:56
README.md Outdated
Comment on lines 199 to 200
[<img src="https://raw.githubusercontent.com/astral-sh/setup-uv/main/docs/images/bmc-button.svg" width=150 height=40 style="margin: 5px"/>](https://www.buymeacoffee.com/eifinger)
[<img src="https://raw.githubusercontent.com/astral-sh/setup-uv/main/docs/images/paypal-button.svg" width=150 height=40 style="margin: 5px"/>](https://paypal.me/kevinstillhammer)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should remove these right?

Screenshot 2024-09-04 at 4 04 55 PM

## Acknowledgements

`setup-uv` was initially written and published by [Kevin Stillhammer](https://github.com/eifinger)
before moving under the official [Astral](https://github.com/astral-sh) GitHub organization. You
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this added paragraph let's remove the images in the docs directory and the links above. Alines better with the other astral repos

@charliermarsh charliermarsh merged commit 6f825bd into main Sep 4, 2024
38 checks passed
@charliermarsh charliermarsh deleted the charlie/ack branch September 4, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants