Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exported VIRTUAL_ENV=... results in warnings #209

Closed
Ravencentric opened this issue Dec 23, 2024 · 2 comments · Fixed by #210
Closed

Exported VIRTUAL_ENV=... results in warnings #209

Ravencentric opened this issue Dec 23, 2024 · 2 comments · Fixed by #210

Comments

@Ravencentric
Copy link

After #194, setup-uv now exports the env var VIRTUAL_ENV. The top level project API (e.g., uv sync) does not respect this and emits the following warning:

warning: `VIRTUAL_ENV=.venv/bin` does not match the project environment path `.venv` and will be ignored` upon invocation.

I understand the reasoning behind the change, but I think it should be opt-in rather than the default.

@eifinger
Copy link
Collaborator

VIRTUAL_ENV should be set to .venv instead of .venv/bin. This is a bug.

Can you explain, why you think this should be opt-in?

@Ravencentric
Copy link
Author

Just to avoid the warnings. If they can be avoided while still unconditionally setting VIRTUAL_ENV=... then I have no strong opinion either way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants