Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rye test: Don't enable capture=no in quiet mode #915

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

bluss
Copy link
Contributor

@bluss bluss commented Mar 21, 2024

rye test -q behaves like pytest -q -s, but the extra -s (no capture == show all standard output) is surprising.

This seems out of place but I don't know if it was deliberate - I suggest this change.

@bluss bluss changed the title Don't enable capture=no in quiet mode rye test: Don't enable capture=no in quiet mode Mar 21, 2024
@mitsuhiko
Copy link
Collaborator

I think this makes sense. Could you also add a changelog entry?

rye test -q behaves like pytest -q -s, but the extra -s (no capture) is
surprising.
@bluss
Copy link
Contributor Author

bluss commented Mar 22, 2024

sure, done

@mitsuhiko mitsuhiko merged commit 0f5196b into astral-sh:main Mar 22, 2024
8 checks passed
@bluss bluss deleted the test-q branch March 22, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants