Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed nextest install line in CONTRIBUTING.md #9929

Merged
merged 3 commits into from
Feb 11, 2024
Merged

Fixed nextest install line in CONTRIBUTING.md #9929

merged 3 commits into from
Feb 11, 2024

Conversation

owenlamont
Copy link
Contributor

@owenlamont owenlamont commented Feb 11, 2024

Summary

I noticed the example line in CONTRIBUTING.md:

cargo install nextest

Didn't appear to install the intended package cargo-nextest.

nextest

So I checked what it should be and replaced the line:

cargo install cargo-nextest --locked

Test Plan

Just checked the cargo install appeared to give sane looking results

Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@charliermarsh charliermarsh added the documentation Improvements or additions to documentation label Feb 11, 2024
@charliermarsh charliermarsh enabled auto-merge (squash) February 11, 2024 15:18
@charliermarsh charliermarsh merged commit a50e278 into astral-sh:main Feb 11, 2024
16 checks passed
nkxxll pushed a commit to nkxxll/ruff that referenced this pull request Mar 10, 2024
## Summary

I noticed the example line in CONTRIBUTING.md:

```shell
cargo install nextest
```

Didn't appear to install the intended package cargo-nextest.


![nextest](https://github.com/astral-sh/ruff/assets/12672027/7bbdd9c3-c35a-464a-b586-3e9f777f8373)

So I checked what it [should
be](https://nexte.st/book/installing-from-source.html) and replaced the
line:

```shell
cargo install cargo-nextest --locked
```

## Test Plan

Just checked the cargo install appeared to give sane looking results

---------

Co-authored-by: Charlie Marsh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants