Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set source type: Stub for black tests with options #9674

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Set source type: Stub for black tests with options #9674

merged 1 commit into from
Jan 29, 2024

Conversation

MichaReiser
Copy link
Member

Summary

Set the source_type for black tests with options to Stub to ensure they run as stubs and not normal Python files.

Test Plan

nested_stub.pyi now shows a diff

@MichaReiser MichaReiser added internal An internal refactor or improvement formatter Related to the formatter labels Jan 29, 2024
@MichaReiser MichaReiser mentioned this pull request Jan 29, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

ruff-ecosystem results

Formatter (stable)

ℹ️ ecosystem check encountered format errors. (no format changes; 1 project error)

openai/openai-cookbook (error) 

warning: Detected debug build without --no-cache.
error: Failed to parse examples/dalle/Image_generations_edits_and_variations_with_DALL-E.ipynb:3:7:8: Unexpected token 'prompt'

Formatter (preview)

ℹ️ ecosystem check encountered format errors. (no format changes; 1 project error)

openai/openai-cookbook (error) 

ruff format --preview

warning: Detected debug build without --no-cache.
error: Failed to parse examples/dalle/Image_generations_edits_and_variations_with_DALL-E.ipynb:3:7:8: Unexpected token 'prompt'

@MichaReiser MichaReiser merged commit 0045032 into main Jan 29, 2024
17 checks passed
@MichaReiser MichaReiser deleted the set-source-type-for-stub-files-in-black-tests branch January 29, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvmanila dhruvmanila Awaiting requested review from dhruvmanila

Assignees
No one assigned
Labels
formatter Related to the formatter internal An internal refactor or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MichaReiser