Add row and column numbers to formatted parse errors #9321
Merged
+88
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
commented
Dec 30, 2023
|
charliermarsh
force-pushed
the
charlie/display-parse-error
branch
from
380a61b to
a043daa
Compare
charliermarsh
added
bug
charliermarsh
force-pushed
the
charlie/display-parse-error
branch
from
a043daa to
34d8bdd
Compare
konstin
approved these changes
Dec 31, 2023
charliermarsh
added a commit
that referenced
this pull request
Dec 31, 2023
## Summary This is a non-behavior-changing refactor to follow-up #9321 by modifying `DisplayParseError` to use owned data and make it useable as a standalone error type (rather than using references and implementing `Display`). I don't feel very strongly either way. I thought it was awkward that the `FormatCommandError` had two branches in the display path, and wanted to represent the `Parse` vs. other cases as a separate enum, so here we are.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We now render parse errors in the formatter identically to those in the linter, e.g.:
Closes #8338.
Closes #9311.