Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect --extend-per-file-ignores on the CLI #8329

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Respect --extend-per-file-ignores on the CLI #8329

merged 1 commit into from
Oct 30, 2023

Conversation

charliermarsh
Copy link
Member

Summary

This field was being dropped from the CLI.

Closes #8328.

@charliermarsh charliermarsh added bug Something isn't working cli Related to the command-line interface labels Oct 29, 2023
@github-actions
Copy link
Contributor

PR Check Results

Ecosystem

✅ ecosystem check detected no linter changes.

MichaReiser
MichaReiser approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could consider removing the CLI option instead. It doesn't seem to have been used widely ;)

@charliermarsh charliermarsh merged commit 221f7cd into main Oct 30, 2023
17 checks passed
@charliermarsh charliermarsh deleted the charlie/extends branch October 30, 2023 00:44
@ofek
Copy link
Contributor

ofek commented Oct 30, 2023

Thank you for the fix, I'm about to use this in Hatch!

@miccal miccal mentioned this pull request Nov 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaReiser MichaReiser MichaReiser approved these changes

@zanieb zanieb Awaiting requested review from zanieb

Assignees
No one assigned
Labels
bug Something isn't working cli Related to the command-line interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

--extend-per-file-ignores isn't respected on the CLI
3 participants
@charliermarsh @ofek @MichaReiser