Allow selective caching for --fix
and --diff
#8316
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If a file has no diagnostics, then we can read and write that information from and to the cache, even if the fix mode is
--fix
or--diff
. (Typically, we can't read or write such results from or to the cache, because--fix
and--diff
have side effects that take place during diagnostic analysis (writing to disk or outputting the diff).) This greatly improves performance when running--fix
on a codebase in the common case (few diagnostics).Closes #8311.
Closes #8315.