Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refurb] Implement isinstance-type-none (FURB168) #8308

Merged
merged 4 commits into from
Oct 28, 2023
Merged

[refurb] Implement isinstance-type-none (FURB168) #8308

merged 4 commits into from
Oct 28, 2023

Conversation

tjkuson
Copy link
Contributor

@tjkuson tjkuson commented Oct 28, 2023 •
edited
Loading

Summary

Implement no-isinstance-type-none as isinstance-type-none (FURB168).

Auto-fixes calls to isinstance to check if an object is None to a None identity check. For example,

isinstance(foo, type(None))

becomes

foo is None

Related to #1348.

Test Plan

cargo test

@tjkuson tjkuson marked this pull request as ready for review October 28, 2023 16:17
@github-actions
Copy link
Contributor

github-actions bot commented Oct 28, 2023 •
edited
Loading

PR Check Results

Ecosystem

✅ ecosystem check detected no linter changes.

@charliermarsh charliermarsh self-assigned this Oct 28, 2023
@charliermarsh charliermarsh added the rule Implementing or modifying a lint rule label Oct 28, 2023
charliermarsh
charliermarsh approved these changes Oct 28, 2023
View reviewed changes
Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great -- thank you!

@charliermarsh charliermarsh enabled auto-merge (squash) October 28, 2023 22:34
@charliermarsh charliermarsh merged commit 10a50bf into astral-sh:main Oct 28, 2023
14 checks passed
@tjkuson tjkuson deleted the isinstance-type-none branch October 30, 2023 09:04
@miccal miccal mentioned this pull request Nov 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliermarsh charliermarsh charliermarsh approved these changes

Assignees

@charliermarsh charliermarsh

Labels
rule Implementing or modifying a lint rule
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tjkuson @charliermarsh