Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect sys.version_info slices in outdated-version-block #8112

Merged
merged 1 commit into from
Oct 21, 2023
Merged

Detect sys.version_info slices in outdated-version-block #8112

merged 1 commit into from
Oct 21, 2023

Conversation

charliermarsh
Copy link
Member

Summary

Given sys.version_info[:2] >= (3,0), we should treat this equivalently to sys.version_info >= (3,0).

Closes #8095.

@charliermarsh charliermarsh added the bug Something isn't working label Oct 21, 2023
@charliermarsh charliermarsh enabled auto-merge (squash) October 21, 2023 23:00
@charliermarsh charliermarsh merged commit 4e07a65 into main Oct 21, 2023
15 checks passed
@charliermarsh charliermarsh deleted the charlie/slice branch October 21, 2023 23:08
@github-actions
Copy link
Contributor

PR Check Results

Ecosystem

ℹ️ ecosystem check detected changes. (+1, -0, 0 error(s))

mypy (+1, -0) 

+ mypy/util.py:413:8: UP036 Version block is outdated for minimum Python version

Rules changed: 1
Rule Changes Additions Removals
UP036 1 1 0

@p-linnane p-linnane mentioned this pull request Oct 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UP036 (outdated-version-block) does not work with slicing
1 participant
@charliermarsh