Accept --target-version in the format CLI
#8055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
added
cli
PR Check ResultsEcosystem✅ ecosystem check detected no changes. |
|
I'm conflicted on this. I find it weird to have no-op flags. |
|
I think we should include it. It’s sort of “incidentally” a no-op. It does set the target version, we’re just not using it in any formatting decisions yet. But we will soon (for preview style, at least). |
|
Yeah. But it's a no-op feature that you can't test. |
MichaReiser
approved these changes
Oct 18, 2023
|
So it must be working... |
|
Does this also get picked up from the standard python-requires, like the target-version for linting (and black does this too)? |
|
Yup, should be, but I will confirm. |
kdeldycke
added a commit
to kdeldycke/workflows
that referenced
this pull request
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This doesn't affect behavior yet (see: #7234), but it will be needed in the future, and it's surprising to users that it doesn't exist.
Closes #8051.