Remove spaces from import statements #7859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // ``` | ||
| if memchr::memchr(b'\\', f.context().source()[self.0.range()].as_bytes()).is_some() { | ||
| text(self.0.as_str(), Some(self.0.start())).fmt(f) | ||
| // The backslashes are line continuations |
There was a problem hiding this comment.
Can we restore the existing comment, and add a second example to explain that there can be arbitrary whitespace between dots? The new comment feels like a less-useful subset of the existing comment.
| .chars() | ||
| .filter(|c| !is_python_whitespace(*c) && !matches!(c, '\n' | '\r' | '\\')) | ||
| .collect(); | ||
| text(&no_whitespace, Some(self.0.start())).fmt(f) |
There was a problem hiding this comment.
Annoying that we pass &str in here only for it to be converted to String internally when formatting, but I don't see any alternative APIs.
There was a problem hiding this comment.
We could change the text element to use Cow, there are more places where we had owned strings previously.
charliermarsh
approved these changes
Oct 9, 2023
**Summary** Remove spaces from import statements such as ```python import tqdm . tqdm from tqdm . auto import tqdm ``` See also #7760 for a better solution. **Test Plan** New fixtures
konstin
force-pushed
the
import-spaces
branch
from
350ea0d
to
5de4bd4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary Remove spaces from import statements such as
See also #7760 for a better solution.
Test Plan New fixtures