-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename ConfigurationOptions
derive macro to OptionsMetadata
#7599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 22, 2023
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
MichaReiser
force-pushed
the
lint-options
branch
from
September 22, 2023 15:49
80e2642
to
8457b88
Compare
MichaReiser
force-pushed
the
rename-configuration-options
branch
from
September 22, 2023 15:49
45f759f
to
a304bab
Compare
CodSpeed Performance ReportMerging #7599 will create unknown performance changesComparing Summary
Benchmarks breakdown
|
PR Check ResultsEcosystem✅ ecosystem check detected no changes. |
MichaReiser
force-pushed
the
lint-options
branch
from
September 22, 2023 16:20
8457b88
to
ca96bc8
Compare
MichaReiser
force-pushed
the
rename-configuration-options
branch
from
September 22, 2023 16:20
a304bab
to
cc8cb51
Compare
MichaReiser
force-pushed
the
lint-options
branch
from
September 22, 2023 16:36
ca96bc8
to
44e112f
Compare
MichaReiser
force-pushed
the
rename-configuration-options
branch
from
September 22, 2023 16:36
cc8cb51
to
68b8ed4
Compare
charliermarsh
approved these changes
Sep 22, 2023
MichaReiser
force-pushed
the
lint-options
branch
from
September 25, 2023 08:40
44e112f
to
a1a72d7
Compare
MichaReiser
force-pushed
the
rename-configuration-options
branch
from
September 25, 2023 08:41
68b8ed4
to
22fd4ee
Compare
MichaReiser
force-pushed
the
lint-options
branch
2 times, most recently
from
September 27, 2023 06:28
5d2086a
to
8827264
Compare
MichaReiser
force-pushed
the
rename-configuration-options
branch
from
September 27, 2023 06:29
22fd4ee
to
2defa2e
Compare
Merge Activity
|
MichaReiser
force-pushed
the
rename-configuration-options
branch
from
September 27, 2023 06:48
2defa2e
to
2aa74bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It's common practice to name derive macros the same as the trait that they implement (
Debug
,Display
,Eq
,Serialize
, ...).This PR renames the
ConfigurationOptions
derive macro toOptionsMetadata
to match the trait name.Test Plan
cargo build