feat(rules): implement `flake8-bandit` `S201` (`flask_debug_true`) #7503

mkniewallner · 2023-09-19T00:03:00Z

Part of #1646.

Summary

Implement S201 (flask_debug_true) rule from bandit.

I am fairly new to Rust and Ruff's codebase, so there might be better ways to implement the rule or write the code.

Test Plan

Snapshot test from https://github.com/PyCQA/bandit/blob/1.7.5/examples/flask_debug.py, with a few additions in the "unrelated" part to test a bit more cases.

codspeed-hq · 2023-09-19T00:12:22Z

CodSpeed Performance Report

Merging #7503 will improve performances by 2.29%

_{Comparing mkniewallner:feat/add-flake8-bandit-S201 (7ed0354) with main (40f6456)}

Summary

⚡ 1 improvements
✅ 24 untouched benchmarks

Benchmarks breakdown

	Benchmark	`main`	`mkniewallner:feat/add-flake8-bandit-S201`	Change
⚡	`linter/all-rules[numpy/ctypeslib.py]`	35 ms	34.3 ms	+2.29%

github-actions · 2023-09-19T00:17:48Z

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

charliermarsh

Looks great! Just some minor stuff.

charliermarsh · 2023-09-19T00:19:11Z

crates/ruff/src/codes.rs

@@ -573,6 +573,7 @@ pub fn code_to_rule(linter: Linter, code: &str) -> Option<(RuleGroup, Rule)> {
        (Flake8Bandit, "110") => (RuleGroup::Unspecified, rules::flake8_bandit::rules::TryExceptPass),
        (Flake8Bandit, "112") => (RuleGroup::Unspecified, rules::flake8_bandit::rules::TryExceptContinue),
        (Flake8Bandit, "113") => (RuleGroup::Unspecified, rules::flake8_bandit::rules::RequestWithoutTimeout),
+        (Flake8Bandit, "201") => (RuleGroup::Unspecified, rules::flake8_bandit::rules::FlaskDebugTrue),


We're now in the habit of adding new rules under RuleGroup::Preview -- mind changing it here?

charliermarsh · 2023-09-19T00:19:34Z

crates/ruff/src/rules/flake8_bandit/rules/flask_debug_true.rs

+/// Checks for uses of `debug=True` in Flask.
+///
+/// ## Why is this bad?
+/// Enabling debug mode shows an interactive debugger in the browser if an error occurs, and allows


It's annoying, but we manually format these to fit 80 characters, since they sometimes get printed to the terminal.

charliermarsh · 2023-09-19T00:20:12Z

crates/ruff/src/rules/flake8_bandit/rules/flask_debug_true.rs

+        return;
+    }
+
+    if let Some(debug_argument) = call.arguments.find_keyword("debug") {


You can reduce one level of indentation by doing:

let Some(debug_argument) = call.arguments.find_keyword("debug") else { return; }; ...

charliermarsh · 2023-09-19T00:20:26Z

crates/ruff/src/rules/flake8_bandit/rules/flask_debug_true.rs

+            return;
+        }
+
+        if let Expr::Name(name) = value.as_ref() {


Same here: can use let-else to reduce indentation.

charliermarsh · 2023-09-19T00:21:06Z

crates/ruff/resources/test/fixtures/flake8_bandit/S201.py

+def main():
+    raise
+
+#bad


For whatever reason, the comment we typically use here is # Errors and then # OK (instead of #okay).

charliermarsh

Thanks!

feat(rules): implement flake8-bandit S201 (flask_debug_true)

2d23862

mkniewallner marked this pull request as ready for review September 19, 2023 00:17

charliermarsh reviewed Sep 19, 2023

View reviewed changes

charliermarsh added the rule Implementing or modifying a lint rule label Sep 19, 2023

mkniewallner added 3 commits September 19, 2023 02:24

feat(rules): move S201 to Preview

c074458

refactor(rules): use let-else

46355ee

test(rules): use consistent wording

7ed0354

charliermarsh approved these changes Sep 19, 2023

View reviewed changes

charliermarsh enabled auto-merge (squash) September 19, 2023 00:39

charliermarsh merged commit c6ba7df into astral-sh:main Sep 19, 2023
14 checks passed

mkniewallner deleted the feat/add-flake8-bandit-S201 branch September 19, 2023 00:53

chenrui333 mentioned this pull request Sep 22, 2023

ruff 0.0.291 Homebrew/homebrew-core#144913

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(rules): implement `flake8-bandit` `S201` (`flask_debug_true`) #7503

feat(rules): implement `flake8-bandit` `S201` (`flask_debug_true`) #7503

mkniewallner commented Sep 19, 2023

codspeed-hq bot commented Sep 19, 2023 •

edited

Loading

github-actions bot commented Sep 19, 2023 •

edited

Loading

charliermarsh left a comment

charliermarsh Sep 19, 2023

charliermarsh Sep 19, 2023

charliermarsh Sep 19, 2023

charliermarsh Sep 19, 2023

charliermarsh Sep 19, 2023

charliermarsh left a comment

feat(rules): implement flake8-bandit S201 (flask_debug_true) #7503

feat(rules): implement flake8-bandit S201 (flask_debug_true) #7503

Conversation

mkniewallner commented Sep 19, 2023

Summary

Test Plan

codspeed-hq bot commented Sep 19, 2023 • edited Loading

CodSpeed Performance Report

Merging #7503 will improve performances by 2.29%

Summary

Benchmarks breakdown

github-actions bot commented Sep 19, 2023 • edited Loading

PR Check Results

Ecosystem

charliermarsh left a comment

Choose a reason for hiding this comment

charliermarsh Sep 19, 2023

Choose a reason for hiding this comment

charliermarsh Sep 19, 2023

Choose a reason for hiding this comment

charliermarsh Sep 19, 2023

Choose a reason for hiding this comment

charliermarsh Sep 19, 2023

Choose a reason for hiding this comment

charliermarsh Sep 19, 2023

Choose a reason for hiding this comment

charliermarsh left a comment

Choose a reason for hiding this comment

feat(rules): implement `flake8-bandit` `S201` (`flask_debug_true`) #7503

feat(rules): implement `flake8-bandit` `S201` (`flask_debug_true`) #7503

codspeed-hq bot commented Sep 19, 2023 •

edited

Loading

github-actions bot commented Sep 19, 2023 •

edited

Loading