Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip serializing cell ID if it's None #6851

Merged
merged 4 commits into from
Aug 24, 2023
Merged

Skip serializing cell ID if it's None #6851

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e193685
Skip serializing cell ID if it's None
harupy Aug 24, 2023
3a3de94
test
harupy Aug 24, 2023
2400288
Apply suggestions from code review
harupy Aug 24, 2023
8a031c4
Revert to using `skip_serializing_if`
dhruvmanila Aug 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions crates/ruff/src/jupyter/schema.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,7 @@ pub struct RawCell {
/// Technically, id isn't required (it's not even present) in schema v4.0 through v4.4, but
/// it's required in v4.5. Main issue is that pycharm creates notebooks without an id
/// <https://youtrack.jetbrains.com/issue/PY-59438/Jupyter-notebooks-created-with-PyCharm-are-missing-the-id-field-in-cells-in-the-.ipynb-json>
#[serde(skip_serializing_if = "Option::is_none")]
harupy marked this conversation as resolved.
Show resolved Hide resolved
pub id: Option<String>,
/// Cell-level metadata.
pub metadata: Value,
Expand All @@ -135,6 +136,7 @@ pub struct MarkdownCell {
/// Technically, id isn't required (it's not even present) in schema v4.0 through v4.4, but
/// it's required in v4.5. Main issue is that pycharm creates notebooks without an id
/// <https://youtrack.jetbrains.com/issue/PY-59438/Jupyter-notebooks-created-with-PyCharm-are-missing-the-id-field-in-cells-in-the-.ipynb-json>
#[serde(skip_serializing_if = "Option::is_none")]
harupy marked this conversation as resolved.
Show resolved Hide resolved
pub id: Option<String>,
/// Cell-level metadata.
pub metadata: Value,
Expand All @@ -150,6 +152,7 @@ pub struct CodeCell {
/// Technically, id isn't required (it's not even present) in schema v4.0 through v4.4, but
/// it's required in v4.5. Main issue is that pycharm creates notebooks without an id
/// <https://youtrack.jetbrains.com/issue/PY-59438/Jupyter-notebooks-created-with-PyCharm-are-missing-the-id-field-in-cells-in-the-.ipynb-json>
#[serde(skip_serializing_if = "Option::is_none")]
harupy marked this conversation as resolved.
Show resolved Hide resolved
pub id: Option<String>,
/// Cell-level metadata.
pub metadata: Value,
Expand Down