Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace inline(always) with inline #6590

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

MichaReiser
Copy link
Member

@MichaReiser MichaReiser commented Aug 15, 2023

Summary

Follow up of this comment.

Replaces all inline(always) with inline except for the few places where it attributes an empty method/function.

Performance

No meaningful change.

Gnuplot not found, using plotters backend
formatter/numpy/globals.py
                        time:   [38.375 µs 38.471 µs 38.589 µs]
                        thrpt:  [76.463 MiB/s 76.698 MiB/s 76.891 MiB/s]
                 change:
                        time:   [-1.5720% -1.1271% -0.7137%] (p = 0.00 < 0.05)
                        thrpt:  [+0.7189% +1.1399% +1.5972%]
                        Change within noise threshold.
formatter/pydantic/types.py
                        time:   [805.00 µs 805.70 µs 806.44 µs]
                        thrpt:  [31.624 MiB/s 31.653 MiB/s 31.681 MiB/s]
                 change:
                        time:   [+0.5153% +0.9531% +1.3701%] (p = 0.00 < 0.05)
                        thrpt:  [-1.3515% -0.9441% -0.5126%]
                        Change within noise threshold.
Found 6 outliers among 100 measurements (6.00%)
  4 (4.00%) high mild
  2 (2.00%) high severe
formatter/numpy/ctypeslib.py
                        time:   [384.13 µs 385.59 µs 387.20 µs]
                        thrpt:  [43.004 MiB/s 43.184 MiB/s 43.347 MiB/s]
                 change:
                        time:   [-4.2419% -3.6520% -3.0507%] (p = 0.00 < 0.05)
                        thrpt:  [+3.1466% +3.7904% +4.4298%]
                        Performance has improved.
Found 11 outliers among 100 measurements (11.00%)
  8 (8.00%) high mild
  3 (3.00%) high severe
formatter/large/dataset.py
                        time:   [2.0589 ms 2.0611 ms 2.0633 ms]
                        thrpt:  [19.717 MiB/s 19.739 MiB/s 19.760 MiB/s]
                 change:
                        time:   [+1.9929% +2.4425% +2.8925%] (p = 0.00 < 0.05)
                        thrpt:  [-2.8112% -2.3843% -1.9539%]
                        Performance has regressed.
Found 1 outliers among 100 measurements (1.00%)
  1 (1.00%) high mild

Test Plan

cargo test

@MichaReiser
Copy link
Member Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@MichaReiser MichaReiser added the internal An internal refactor or improvement label Aug 15, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 15, 2023

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

Benchmark

Linux

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.00      4.4±0.18ms     9.2 MB/sec    1.01      4.5±0.22ms     9.1 MB/sec
formatter/numpy/ctypeslib.py               1.00   877.6±29.29µs    19.0 MB/sec    1.01   884.1±34.91µs    18.8 MB/sec
formatter/numpy/globals.py                 1.00     88.6±6.14µs    33.3 MB/sec    1.00     89.0±4.79µs    33.1 MB/sec
formatter/pydantic/types.py                1.00  1779.3±77.24µs    14.3 MB/sec    1.00  1779.9±63.00µs    14.3 MB/sec
linter/all-rules/large/dataset.py          1.00     12.8±0.41ms     3.2 MB/sec    1.03     13.1±0.34ms     3.1 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      3.4±0.11ms     4.9 MB/sec    1.01      3.5±0.12ms     4.8 MB/sec
linter/all-rules/numpy/globals.py          1.01   506.5±28.80µs     5.8 MB/sec    1.00   503.7±23.87µs     5.9 MB/sec
linter/all-rules/pydantic/types.py         1.00      6.7±0.26ms     3.8 MB/sec    1.00      6.7±0.20ms     3.8 MB/sec
linter/default-rules/large/dataset.py      1.00      6.7±0.20ms     6.1 MB/sec    1.03      6.9±0.19ms     5.9 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00  1478.7±57.28µs    11.3 MB/sec    1.01  1494.0±53.20µs    11.1 MB/sec
linter/default-rules/numpy/globals.py      1.00    186.7±8.08µs    15.8 MB/sec    1.00   186.3±11.15µs    15.8 MB/sec
linter/default-rules/pydantic/types.py     1.00      3.0±0.09ms     8.4 MB/sec    1.02      3.1±0.13ms     8.2 MB/sec

Windows

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.00      3.0±0.03ms    13.5 MB/sec    1.01      3.0±0.03ms    13.4 MB/sec
formatter/numpy/ctypeslib.py               1.00   569.4±11.37µs    29.2 MB/sec    1.00    571.7±7.81µs    29.1 MB/sec
formatter/numpy/globals.py                 1.00     58.3±2.93µs    50.6 MB/sec    1.01     58.9±0.79µs    50.1 MB/sec
formatter/pydantic/types.py                1.00  1179.3±28.62µs    21.6 MB/sec    1.01  1195.9±24.27µs    21.3 MB/sec
linter/all-rules/large/dataset.py          1.00      9.3±0.05ms     4.4 MB/sec    1.01      9.3±0.05ms     4.4 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      2.6±0.02ms     6.4 MB/sec    1.00      2.6±0.02ms     6.4 MB/sec
linter/all-rules/numpy/globals.py          1.00    270.7±3.65µs    10.9 MB/sec    1.01    272.6±4.08µs    10.8 MB/sec
linter/all-rules/pydantic/types.py         1.00      4.9±0.04ms     5.3 MB/sec    1.00      4.9±0.04ms     5.2 MB/sec
linter/default-rules/large/dataset.py      1.00      5.1±0.03ms     8.0 MB/sec    1.00      5.1±0.04ms     8.0 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00   1057.8±7.18µs    15.7 MB/sec    1.01   1066.3±8.93µs    15.6 MB/sec
linter/default-rules/numpy/globals.py      1.00    108.9±1.56µs    27.1 MB/sec    1.01    110.0±1.56µs    26.8 MB/sec
linter/default-rules/pydantic/types.py     1.00      2.3±0.02ms    11.1 MB/sec    1.00      2.3±0.02ms    11.1 MB/sec

@MichaReiser MichaReiser merged commit 455db84 into main Aug 15, 2023
@MichaReiser MichaReiser deleted the replace-inline-always-with-inline branch August 15, 2023 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant