-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Printer: Remove unused state fields #6548
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
This was referenced Aug 14, 2023
PR Check ResultsBenchmarkLinux
Windows
|
This was referenced Aug 14, 2023
konstin
approved these changes
Aug 14, 2023
MichaReiser
force-pushed
the
remove-unused-printer-fields
branch
from
August 14, 2023 08:21
7f83eeb
to
055af52
Compare
Merged
Base automatically changed from
formatter-bench-only-measure-formatting-time
to
main
August 14, 2023 08:25
MichaReiser
force-pushed
the
remove-unused-printer-fields
branch
from
August 14, 2023 08:26
055af52
to
8eb36fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the two
generated_*
fields that thePrinter
only ever wrote to but never read. I further changed theline_width
to au32
because it is sufficient to support files up to 4GBTest Plan
cargo test