Change TODO directive detection to work with multiple pound signs on the same line #4558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanrittenhouse
commented
May 21, 2023
PR Check ResultsEcosystemℹ️ ecosystem check detected changes. (+95, -105, 0 error(s)) airflow (+15, -11)
- airflow/cli/commands/task_command.py:456:7: TD005 Missing issue description after `TODO`
- airflow/cli/commands/task_command.py:663:11: TD005 Missing issue description after `TODO`
- airflow/decorators/base.py:216:11: TD005 Missing issue description after `TODO`
- airflow/jobs/local_task_job_runner.py:79:41: TD005 Missing issue description after `TODO`
+ airflow/jobs/scheduler_job_runner.py:1183:11: TD004 Missing colon in TODO
+ airflow/jobs/scheduler_job_runner.py:1427:11: TD004 Missing colon in TODO
+ airflow/jobs/scheduler_job_runner.py:402:15: TD004 Missing colon in TODO
+ airflow/jobs/scheduler_job_runner.py:592:19: TD004 Missing colon in TODO
- airflow/models/baseoperator.py:1235:40: TD005 Missing issue description after `TODO`
- airflow/models/dag.py:1477:19: TD005 Missing issue description after `TODO`
+ airflow/models/dagrun.py:1184:15: TD004 Missing colon in TODO
+ airflow/providers/google/cloud/sensors/tasks.py:80:11: TD004 Missing colon in TODO
- airflow/providers/google/cloud/sensors/tasks.py:80:11: TD007 Missing space after colon in TODO
- airflow/providers/jenkins/operators/jenkins_job_trigger.py:153:11: TD005 Missing issue description after `TODO`
- airflow/task/task_runner/cgroup_task_runner.py:171:11: TD005 Missing issue description after `TODO`
- airflow/www/views.py:4091:11: TD005 Missing issue description after `TODO`
+ airflow/www/views.py:5196:22: TD002 Missing author in TODO; try: `# TODO(<author_name>): ...`
+ airflow/www/views.py:5196:22: TD003 Missing issue link on the line following this TODO
+ airflow/www/views.py:5196:22: TD006 [*] Invalid TODO capitalization: `todo` should be `TODO`
+ airflow/www/views.py:5223:21: TD002 Missing author in TODO; try: `# TODO(<author_name>): ...`
+ airflow/www/views.py:5223:21: TD003 Missing issue link on the line following this TODO
+ airflow/www/views.py:5223:21: TD006 [*] Invalid TODO capitalization: `todo` should be `TODO`
+ airflow/www/views.py:5594:22: TD002 Missing author in TODO; try: `# TODO(<author_name>): ...`
+ airflow/www/views.py:5594:22: TD003 Missing issue link on the line following this TODO
+ airflow/www/views.py:5594:22: TD006 [*] Invalid TODO capitalization: `todo` should be `TODO`
- tests/utils/test_config.py:27:3: TD005 Missing issue description after `TODO`bokeh (+62, -84)
- release/credentials.py:77:7: TD005 Missing issue description after `TODO`
- release/credentials.py:84:7: TD005 Missing issue description after `TODO`
- src/bokeh/application/application.py:187:15: TD005 Missing issue description after `TODO`
- src/bokeh/application/handlers/code.py:168:11: TD005 Missing issue description after `TODO`
- src/bokeh/application/handlers/directory.py:313:15: TD005 Missing issue description after `TODO`
- src/bokeh/application/handlers/server_lifecycle.py:127:15: TD005 Missing issue description after `TODO`
- src/bokeh/application/handlers/server_request_handler.py:120:15: TD005 Missing issue description after `TODO`
- src/bokeh/client/connection.py:349:19: TD005 Missing issue description after `TODO`
+ src/bokeh/core/has_props.py:440:99: TD002 Missing author in TODO; try: `# TODO(<author_name>): ...`
+ src/bokeh/core/has_props.py:440:99: TD003 Missing issue link on the line following this TODO
- src/bokeh/core/has_props.py:630:15: TD005 Missing issue description after `TODO`
- src/bokeh/core/property/wrappers.py:466:11: TD005 Missing issue description after `TODO`
- src/bokeh/core/property_mixins.py:374:41: TD005 Missing issue description after `TODO`
- src/bokeh/document/document.py:401:11: TD005 Missing issue description after `TODO`
- src/bokeh/document/models.py:241:7: TD005 Missing issue description after `TODO`
+ src/bokeh/embed/standalone.py:137:79: TD001 Invalid TODO tag: `XXX`
+ src/bokeh/embed/standalone.py:137:79: TD002 Missing author in TODO; try: `# TODO(<author_name>): ...`
+ src/bokeh/embed/standalone.py:137:79: TD003 Missing issue link on the line following this TODO
+ src/bokeh/embed/standalone.py:144:89: TD001 Invalid TODO tag: `XXX`
+ src/bokeh/embed/standalone.py:144:89: TD002 Missing author in TODO; try: `# TODO(<author_name>): ...`
+ src/bokeh/embed/standalone.py:144:89: TD003 Missing issue link on the line following this TODO
+ src/bokeh/embed/standalone.py:151:90: TD001 Invalid TODO tag: `XXX`
+ src/bokeh/embed/standalone.py:151:90: TD002 Missing author in TODO; try: `# TODO(<author_name>): ...`
+ src/bokeh/embed/standalone.py:151:90: TD003 Missing issue link on the line following this TODO
+ src/bokeh/embed/standalone.py:255:61: TD001 Invalid TODO tag: `XXX`
+ src/bokeh/embed/standalone.py:255:61: TD002 Missing author in TODO; try: `# TODO(<author_name>): ...`
+ src/bokeh/embed/standalone.py:255:61: TD003 Missing issue link on the line following this TODO
- src/bokeh/io/showing.py:148:48: TD005 Missing issue description after `TODO`
+ src/bokeh/layouts.py:303:3: TD004 Missing colon in TODO
- src/bokeh/layouts.py:303:3: TD007 Missing space after colon in TODO
- src/bokeh/models/map_plots.py:172:7: TD005 Missing issue description after `TODO`
- src/bokeh/models/sources.py:224:11: TD005 Missing issue description after `TODO`
- src/bokeh/models/tools.py:884:7: TD005 Missing issue description after `TODO`
- src/bokeh/plotting/_docstring.py:107:7: TD005 Missing issue description after `TODO`
+ src/bokeh/server/tornado.py:432:86: TD002 Missing author in TODO; try: `# TODO(<author_name>): ...`
+ src/bokeh/server/tornado.py:432:86: TD003 Missing issue link on the line following this TODO
+ src/bokeh/server/tornado.py:449:82: TD002 Missing author in TODO; try: `# TODO(<author_name>): ...`
+ src/bokeh/server/tornado.py:449:82: TD003 Missing issue link on the line following this TODO
+ src/bokeh/server/tornado.py:452:78: TD002 Missing author in TODO; try: `# TODO(<author_name>): ...`
+ src/bokeh/server/tornado.py:452:78: TD003 Missing issue link on the line following this TODO
+ src/bokeh/server/tornado.py:458:67: TD002 Missing author in TODO; try: `# TODO(<author_name>): ...`
+ src/bokeh/server/tornado.py:458:67: TD003 Missing issue link on the line following this TODO
- src/bokeh/server/tornado.py:653:11: TD005 Missing issue description after `TODO`
- src/bokeh/sphinxext/util.py:47:3: TD005 Missing issue description after `TODO`
- src/bokeh/util/callback_manager.py:61:3: TD005 Missing issue description after `TODO`
- src/bokeh/util/serialization.py:202:7: TD005 Missing issue description after `TODO`
- src/bokeh/util/serialization.py:239:7: TD005 Missing issue description after `TODO`
+ src/typings/IPython/core/history.pyi:5:89: TD001 Invalid TODO tag: `XXX`
+ src/typings/IPython/core/history.pyi:5:89: TD002 Missing author in TODO; try: `# TODO(<author_name>): ...`
+ src/typings/IPython/core/history.pyi:5:89: TD003 Missing issue link on the line following this TODO
- tests/integration/tools/test_range_tool.py:36:3: TD005 Missing issue description after `TODO`
- tests/integration/tools/test_range_tool.py:37:3: TD005 Missing issue description after `TODO`
- tests/integration/tools/test_reset_tool.py:104:11: TD005 Missing issue description after `TODO`
- tests/integration/tools/test_reset_tool.py:125:61: TD005 Missing issue description after `TODO`
- tests/integration/tools/test_tap_tool.py:34:3: TD007 Missing space after colon in TODO
+ tests/integration/widgets/tables/test_cell_editors.py:101:13: TD002 Missing author in TODO; try: `# TODO(<author_name>): ...`
+ tests/integration/widgets/tables/test_cell_editors.py:101:13: TD003 Missing issue link on the line following this TODO
+ tests/integration/widgets/tables/test_cell_editors.py:101:13: TD004 Missing colon in TODO
+ tests/integration/widgets/tables/test_cell_editors.py:101:13: TD005 Missing issue description after `TODO`
- tests/integration/widgets/tables/test_cell_editors.py:351:3: TD005 Missing issue description after `TODO`
- tests/integration/widgets/tables/test_cell_editors.py:59:3: TD005 Missing issue description after `TODO`
+ tests/integration/widgets/tables/test_cell_editors.py:79:13: TD002 Missing author in TODO; try: `# TODO(<author_name>): ...`
+ tests/integration/widgets/tables/test_cell_editors.py:79:13: TD003 Missing issue link on the line following this TODO
+ tests/integration/widgets/tables/test_cell_editors.py:79:13: TD004 Missing colon in TODO
+ tests/integration/widgets/tables/test_cell_editors.py:79:13: TD005 Missing issue description after `TODO`
- tests/integration/widgets/tables/test_copy_paste.py:143:11: TD005 Missing issue description after `TODO`
+ tests/integration/widgets/test_color_picker.py:107:11: TD004 Missing colon in TODO
- tests/integration/widgets/test_color_picker.py:107:11: TD007 Missing space after colon in TODO
+ tests/integration/widgets/test_daterange_slider.py:160:13: TD001 Invalid TODO tag: `XXX`
+ tests/integration/widgets/test_daterange_slider.py:160:13: TD003 Missing issue link on the line following this TODO
+ tests/integration/widgets/test_daterange_slider.py:160:13: TD004 Missing colon in TODO
+ tests/integration/widgets/test_daterange_slider.py:169:13: TD001 Invalid TODO tag: `XXX`
+ tests/integration/widgets/test_daterange_slider.py:169:13: TD003 Missing issue link on the line following this TODO
+ tests/integration/widgets/test_daterange_slider.py:169:13: TD004 Missing colon in TODO
+ tests/integration/widgets/test_daterange_slider.py:192:11: TD004 Missing colon in TODO
- tests/integration/widgets/test_daterange_slider.py:192:11: TD007 Missing space after colon in TODO
- tests/integration/widgets/test_dateslider.py:154:11: TD005 Missing issue description after `TODO`
+ tests/integration/widgets/test_dateslider.py:163:11: TD004 Missing colon in TODO
- tests/integration/widgets/test_dateslider.py:163:11: TD007 Missing space after colon in TODO
+ tests/integration/widgets/test_dateslider.py:197:11: TD004 Missing colon in TODO
- tests/integration/widgets/test_dateslider.py:197:11: TD007 Missing space after colon in TODO
+ tests/integration/widgets/test_dateslider.py:220:11: TD004 Missing colon in TODO
- tests/integration/widgets/test_dateslider.py:220:11: TD007 Missing space after colon in TODO
+ tests/integration/widgets/test_dateslider.py:243:11: TD004 Missing colon in TODO
- tests/integration/widgets/test_dateslider.py:243:11: TD007 Missing space after colon in TODO
- tests/integration/widgets/test_dropdown.py:42:3: TD005 Missing issue description after `TODO`
- tests/integration/widgets/test_range_slider.py:211:11: TD005 Missing issue description after `TODO`
+ tests/integration/widgets/test_range_slider.py:220:11: TD004 Missing colon in TODO
- tests/integration/widgets/test_range_slider.py:220:11: TD007 Missing space after colon in TODO
+ tests/integration/widgets/test_range_slider.py:243:11: TD004 Missing colon in TODO
- tests/integration/widgets/test_range_slider.py:243:11: TD007 Missing space after colon in TODO
- tests/integration/widgets/test_slider.py:177:11: TD005 Missing issue description after `TODO`
+ tests/integration/widgets/test_slider.py:186:11: TD004 Missing colon in TODO
- tests/integration/widgets/test_slider.py:186:11: TD007 Missing space after colon in TODO
+ tests/integration/widgets/test_slider.py:220:11: TD004 Missing colon in TODO
- tests/integration/widgets/test_slider.py:220:11: TD007 Missing space after colon in TODO
+ tests/integration/widgets/test_slider.py:243:11: TD004 Missing colon in TODO
- tests/integration/widgets/test_slider.py:243:11: TD007 Missing space after colon in TODO
+ tests/integration/widgets/test_slider.py:266:11: TD004 Missing colon in TODO
- tests/integration/widgets/test_slider.py:266:11: TD007 Missing space after colon in TODO
+ tests/integration/widgets/test_spinner.py:228:11: TD004 Missing colon in TODO
- tests/integration/widgets/test_spinner.py:228:11: TD007 Missing space after colon in TODO
- tests/integration/widgets/test_toggle.py:105:7: TD005 Missing issue description after `TODO`
+ tests/support/plugins/bokeh_server.py:103:66: TD001 Invalid TODO tag: `XXX`
+ tests/support/plugins/bokeh_server.py:103:66: TD002 Missing author in TODO; try: `# TODO(<author_name>): ...`
+ tests/support/plugins/bokeh_server.py:103:66: TD003 Missing issue link on the line following this TODO
+ tests/support/plugins/bokeh_server.py:86:48: TD001 Invalid TODO tag: `XXX`
+ tests/support/plugins/bokeh_server.py:86:48: TD002 Missing author in TODO; try: `# TODO(<author_name>): ...`
+ tests/support/plugins/bokeh_server.py:86:48: TD003 Missing issue link on the line following this TODO
+ tests/support/plugins/project.py:162:15: TD004 Missing colon in TODO
- tests/support/plugins/project.py:162:15: TD007 Missing space after colon in TODO
- tests/unit/bokeh/core/property/test_aliases.py:78:3: TD005 Missing issue description after `TODO`
- tests/unit/bokeh/core/property/test_bases.py:156:11: TD005 Missing issue description after `TODO`
- tests/unit/bokeh/core/property/test_bases.py:188:11: TD005 Missing issue description after `TODO`
- tests/unit/bokeh/core/property/test_bases.py:205:11: TD005 Missing issue description after `TODO`
- tests/unit/bokeh/core/property/test_container.py:62:3: TD005 Missing issue description after `TODO`
- tests/unit/bokeh/core/property/test_datetime.py:170:3: TD005 Missing issue description after `TODO`
- tests/unit/bokeh/core/property/test_either.py:66:11: TD005 Missing issue description after `TODO`
- tests/unit/bokeh/core/property/test_numeric.py:122:11: TD005 Missing issue description after `TODO`
- tests/unit/bokeh/core/property/test_numeric.py:160:11: TD005 Missing issue description after `TODO`
- tests/unit/bokeh/core/property/test_numeric.py:199:11: TD005 Missing issue description after `TODO`
- tests/unit/bokeh/core/property/test_numeric.py:237:11: TD005 Missing issue description after `TODO`
- tests/unit/bokeh/core/property/test_numeric.py:286:11: TD005 Missing issue description after `TODO`
- tests/unit/bokeh/core/property/test_numeric.py:53:11: TD005 Missing issue description after `TODO`
- tests/unit/bokeh/core/property/test_numeric.py:94:11: TD005 Missing issue description after `TODO`
- tests/unit/bokeh/core/property/test_primitive.py:155:11: TD005 Missing issue description after `TODO`
- tests/unit/bokeh/core/property/test_primitive.py:214:11: TD005 Missing issue description after `TODO`
- tests/unit/bokeh/core/property/test_primitive.py:344:11: TD005 Missing issue description after `TODO`
- tests/unit/bokeh/core/property/test_validation__property.py:120:7: TD005 Missing issue description after `TODO`
- tests/unit/bokeh/core/property/test_validation__property.py:264:7: TD005 Missing issue description after `TODO`
- tests/unit/bokeh/core/test_properties.py:152:3: TD005 Missing issue description after `TODO`
- tests/unit/bokeh/document/test_callbacks__document.py:179:52: TD005 Missing issue description after `TODO`
- tests/unit/bokeh/document/test_callbacks__document.py:378:7: TD005 Missing issue description after `TODO`
- tests/unit/bokeh/document/test_callbacks__document.py:379:7: TD005 Missing issue description after `TODO`
- tests/unit/bokeh/document/test_document.py:1014:7: TD005 Missing issue description after `TODO`
- tests/unit/bokeh/document/test_document.py:1016:7: TD005 Missing issue description after `TODO`
- tests/unit/bokeh/document/test_events__document.py:159:7: TD005 Missing issue description after `TODO`
- tests/unit/bokeh/model/test_util_model.py:127:7: TD005 Missing issue description after `TODO`
- tests/unit/bokeh/model/test_util_model.py:61:3: TD005 Missing issue description after `TODO`
- tests/unit/bokeh/models/test_tools.py:7:3: TD005 Missing issue description after `TODO`
+ tests/unit/bokeh/plotting/test__renderer.py:115:5: TD002 Missing author in TODO; try: `# TODO(<author_name>): ...`
+ tests/unit/bokeh/plotting/test__renderer.py:115:5: TD003 Missing issue link on the line following this TODO
- tests/unit/bokeh/plotting/test_figure.py:536:7: TD005 Missing issue description after `TODO`
- tests/unit/bokeh/test___init__.py:101:7: TD005 Missing issue description after `TODO`
- tests/unit/bokeh/test_client_server.py:670:58: TD005 Missing issue description after `TODO`
- tests/unit/bokeh/test_tile_providers.py:79:3: TD005 Missing issue description after `TODO`zulip (+18, -10)
- corporate/lib/stripe.py:603:7: TD005 Missing issue description after `TODO`
- corporate/models.py:264:7: TD005 Missing issue description after `TODO`
- tools/lib/provision.py:290:15: TD005 Missing issue description after `TODO`
- zerver/data_import/gitter.py:132:7: TD005 Missing issue description after `TODO`
- zerver/data_import/slack.py:570:15: TD005 Missing issue description after `TODO`
+ zerver/lib/compatibility.py:150:7: TD004 Missing colon in TODO
+ zerver/lib/email_notifications.py:610:11: TD004 Missing colon in TODO
+ zerver/lib/events.py:470:11: TD004 Missing colon in TODO
- zerver/lib/import_realm.py:682:7: TD005 Missing issue description after `TODO`
+ zerver/lib/message.py:1157:35: TD002 Missing author in TODO; try: `# TODO(<author_name>): ...`
+ zerver/lib/message.py:1157:35: TD003 Missing issue link on the line following this TODO
+ zerver/lib/narrow.py:278:15: TD004 Missing colon in TODO
+ zerver/lib/push_notifications.py:1049:11: TD004 Missing colon in TODO
- zerver/lib/push_notifications.py:155:7: TD005 Missing issue description after `TODO`
- zerver/lib/push_notifications.py:227:11: TD005 Missing issue description after `TODO`
+ zerver/lib/retention.py:365:32: TD002 Missing author in TODO; try: `# TODO(<author_name>): ...`
+ zerver/lib/retention.py:365:32: TD003 Missing issue link on the line following this TODO
+ zerver/lib/retention.py:365:32: TD004 Missing colon in TODO
+ zerver/lib/retention.py:365:32: TD005 Missing issue description after `TODO`
+ zerver/lib/sessions.py:66:54: TD002 Missing author in TODO; try: `# TODO(<author_name>): ...`
+ zerver/lib/sessions.py:66:54: TD003 Missing issue link on the line following this TODO
- zerver/lib/test_helpers.py:535:28: TD005 Missing issue description after `TODO`
- zerver/management/commands/convert_gitter_data.py:46:15: TD005 Missing issue description after `TODO`
+ zerver/tornado/event_queue.py:1141:7: TD004 Missing colon in TODO
+ zerver/tornado/event_queue.py:1153:7: TD004 Missing colon in TODO
+ zerver/tornado/event_queue.py:1326:11: TD004 Missing colon in TODO
+ zerver/tornado/event_queue.py:1345:15: TD004 Missing colon in TODO
+ zerver/tornado/event_queue.py:1360:15: TD004 Missing colon in TODO
BenchmarkLinuxWindows |
Closed
MichaReiser
reviewed
May 22, 2023
There was a problem hiding this comment.
Would you mind adding a short description to your summary of what this PR fixes. I read the issue and I believe I know what it is about, but I'm unsure.
@evanrittenhouse did you review the ecosystem checks. Do the new violations look legit?
|
@MichaReiser PR updated! I reviewed some of the violations yesterday, but finished looking at them today. The only one that looks slightly wonky is this one, where The line causing the issue is here, where we |
evanrittenhouse
force-pushed
the
4549_flake8_todo_falseneg
branch
from
db04423 to
5f55540
Compare
|
@evanrittenhouse thanks for the explanation. To double check. Do you mean this line https://github.com/bokeh/bokeh/blob/f4c7a9787f0fd93db6987cfbb46409098ddb3107/tests/integration/widgets/test_daterange_slider.py#L169 ?
That makes sense. Trimming the leading whitespace and then testing the character should give us better results. |
|
@MichaReiser Yep, that's the one! Sorry, misclicked the copy-paste. I've pushed a fix to this PR just now. Seems like there have been some changes, so I'll have to investigate them after work and make sure that they're valid E: Seems like the big issue is a bunch of |
evanrittenhouse
changed the title
|
Hmm. So I copied one of the files that changed according to the ecosystem check ( @MichaReiser do you have any idea what could be happening? |
|
@evanrittenhouse the results from the ecosystem check seem correct. On Add test for colons that don't terminate the tag/author block. cargo run --bin ruff -- check --no-cache ~/Downloads/credentials.py --select TD Finished dev [unoptimized + debuginfo] target(s) in 0.10s Running `target/debug/ruff check --no-cache /home/micha/Downloads/credentials.py --select TD` /home/micha/Downloads/credentials.py:77:7: TD002 Missing author in TODO; try: `# TODO(<author_name>): ...` /home/micha/Downloads/credentials.py:77:7: TD003 Missing issue link on the line following this TODO /home/micha/Downloads/credentials.py:77:7: TD004 Missing colon in TODO /home/micha/Downloads/credentials.py:77:7: TD005 Missing issue description after `TODO` /home/micha/Downloads/credentials.py:84:7: TD002 Missing author in TODO; try: `# TODO(<author_name>): ...` /home/micha/Downloads/credentials.py:84:7: TD003 Missing issue link on the line following this TODO /home/micha/Downloads/credentials.py:84:7: TD004 Missing colon in TODO /home/micha/Downloads/credentials.py:84:7: TD005 Missing issue description after `TODO` Found 8 errors. On the latest commit cargo run --bin ruff -- check --no-cache ~/Downloads/credentials.py --select TD Compiling ruff v0.0.269 (/home/micha/astral/ruff/crates/ruff) Compiling ruff_cli v0.0.269 (/home/micha/astral/ruff/crates/ruff_cli) Finished dev [unoptimized + debuginfo] target(s) in 6.78s Running `target/debug/ruff check --no-cache /home/micha/Downloads/credentials.py --select TD` /home/micha/Downloads/credentials.py:77:7: TD002 Missing author in TODO; try: `# TODO(<author_name>): ...` /home/micha/Downloads/credentials.py:77:7: TD003 Missing issue link on the line following this TODO /home/micha/Downloads/credentials.py:77:7: TD004 Missing colon in TODO /home/micha/Downloads/credentials.py:84:7: TD002 Missing author in TODO; try: `# TODO(<author_name>): ...` /home/micha/Downloads/credentials.py:84:7: TD003 Missing issue link on the line following this TODO /home/micha/Downloads/credentials.py:84:7: TD004 Missing colon in TODO Found 6 errors. You can see that the diagnostics for TD005 are missing. I think this is correct because there's a description. |
MichaReiser
approved these changes
May 24, 2023
evanrittenhouse
force-pushed
the
4549_flake8_todo_falseneg
branch
from
d2329bb to
4f12a46
Compare
evanrittenhouse
force-pushed
the
4549_flake8_todo_falseneg
branch
from
4f12a46 to
41f4002
Compare
|
@MichaReiser Thanks for the suggestions! |
renovate bot
referenced
this pull request
in ixm-one/pytest-cmake-presets
Jun 7, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://togithub.com/charliermarsh/ruff) ([changelog](https://togithub.com/charliermarsh/ruff/releases)) | `^0.0.270` -> `^0.0.271` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>charliermarsh/ruff</summary> ### [`v0.0.271`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.271) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.270...v0.0.271) <!-- Release notes generated using configuration in .github/release.yml at main --> #### What's Changed ##### Rules - Add autofix for flake8-type-checking by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4742](https://togithub.com/charliermarsh/ruff/pull/4742) - \[`airflow`] Add AIR001: task variable name should be same as task_id arg by [@​jlaneve](https://togithub.com/jlaneve) in [https://github.com/charliermarsh/ruff/pull/4687](https://togithub.com/charliermarsh/ruff/pull/4687) - \[`flake8-bandit`] Implement S609, linux_commands_wildcard_injection by [@​scop](https://togithub.com/scop) in [https://github.com/charliermarsh/ruff/pull/4504](https://togithub.com/charliermarsh/ruff/pull/4504) - \[`flake8-bugbear`] Move duplicate-value rule to flake8-bugbear by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4882](https://togithub.com/charliermarsh/ruff/pull/4882) - \[`flake8-fixme`] Implement `flake8_fixme` and refactor `TodoDirective` by [@​evanrittenhouse](https://togithub.com/evanrittenhouse) in [https://github.com/charliermarsh/ruff/pull/4681](https://togithub.com/charliermarsh/ruff/pull/4681) - \[`flake8-future-annotations`] Implement `FA102` by [@​akx](https://togithub.com/akx) in [https://github.com/charliermarsh/ruff/pull/4702](https://togithub.com/charliermarsh/ruff/pull/4702) - \[`flake8-pyi`] Add PYI024 for `flake8-pyi` plugin by [@​qdegraaf](https://togithub.com/qdegraaf) in [https://github.com/charliermarsh/ruff/pull/4756](https://togithub.com/charliermarsh/ruff/pull/4756) - \[`flake8-pyi`] Add PYI034 for `flake8-pyi` plugin by [@​qdegraaf](https://togithub.com/qdegraaf) in [https://github.com/charliermarsh/ruff/pull/4764](https://togithub.com/charliermarsh/ruff/pull/4764) - \[`flake8-pyi`] Add `PYI032` rule with autofix by [@​qdegraaf](https://togithub.com/qdegraaf) in [https://github.com/charliermarsh/ruff/pull/4695](https://togithub.com/charliermarsh/ruff/pull/4695) - \[`flake8-pyi`] Add autofix for PYI010 by [@​qdegraaf](https://togithub.com/qdegraaf) in [https://github.com/charliermarsh/ruff/pull/4634](https://togithub.com/charliermarsh/ruff/pull/4634) - \[`flake8-pyi`] Implement PYI029 by [@​density](https://togithub.com/density) in [https://github.com/charliermarsh/ruff/pull/4851](https://togithub.com/charliermarsh/ruff/pull/4851) - \[`flake8-pyi`] Implement PYI035 by [@​density](https://togithub.com/density) in [https://github.com/charliermarsh/ruff/pull/4820](https://togithub.com/charliermarsh/ruff/pull/4820) - \[`flake8-pyi`] Implement PYI048 for `flake8-pyi` plugin by [@​qdegraaf](https://togithub.com/qdegraaf) in [https://github.com/charliermarsh/ruff/pull/4645](https://togithub.com/charliermarsh/ruff/pull/4645) - \[`flake8-pyi`] Implement PYI053 by [@​density](https://togithub.com/density) in [https://github.com/charliermarsh/ruff/pull/4770](https://togithub.com/charliermarsh/ruff/pull/4770) - \[`flake8-pyi`] Implement PYI054 by [@​density](https://togithub.com/density) in [https://github.com/charliermarsh/ruff/pull/4775](https://togithub.com/charliermarsh/ruff/pull/4775) - \[`flake8-pyi`] Implement `PYI025` by [@​qdegraaf](https://togithub.com/qdegraaf) in [https://github.com/charliermarsh/ruff/pull/4791](https://togithub.com/charliermarsh/ruff/pull/4791) - \[`flake8-pyi`] Implement `PYI045` by [@​density](https://togithub.com/density) in [https://github.com/charliermarsh/ruff/pull/4700](https://togithub.com/charliermarsh/ruff/pull/4700) - \[`pylint`] Add Pylint rule `C0208` (`use-sequence-for-iteration`) as `PLC0208` (`iteration-over-set`) by [@​tjkuson](https://togithub.com/tjkuson) in [https://github.com/charliermarsh/ruff/pull/4706](https://togithub.com/charliermarsh/ruff/pull/4706) - \[`pylint`] Add autofix for `PLR1701` (repeated-isinstance-calls) by [@​dhruvmanila](https://togithub.com/dhruvmanila) in [https://github.com/charliermarsh/ruff/pull/4792](https://togithub.com/charliermarsh/ruff/pull/4792) - \[`pylint`] Implement Pylint's `yield-inside-async-function` rule (`PLE1700`) by [@​chanman3388](https://togithub.com/chanman3388) in [https://github.com/charliermarsh/ruff/pull/4668](https://togithub.com/charliermarsh/ruff/pull/4668) - \[`pylint`] implement E307 for pylint invalid str return type by [@​Ryang20718](https://togithub.com/Ryang20718) in [https://github.com/charliermarsh/ruff/pull/4854](https://togithub.com/charliermarsh/ruff/pull/4854) - \[`ruff`] Lint pyproject.toml by [@​konstin](https://togithub.com/konstin) in [https://github.com/charliermarsh/ruff/pull/4496](https://togithub.com/charliermarsh/ruff/pull/4496) - \[`tryceratops`] Ignore error calls with `exc_info` in TRY400 by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4797](https://togithub.com/charliermarsh/ruff/pull/4797) ##### Settings - Add `pyflakes.extend-generics` setting by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [https://github.com/charliermarsh/ruff/pull/4677](https://togithub.com/charliermarsh/ruff/pull/4677) ##### Bug Fixes - Fix PLW3301 false positive single argument nested min/max by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [https://github.com/charliermarsh/ruff/pull/4683](https://togithub.com/charliermarsh/ruff/pull/4683) - Handle dotted alias imports to check for implicit imports by [@​dhruvmanila](https://togithub.com/dhruvmanila) in [https://github.com/charliermarsh/ruff/pull/4685](https://togithub.com/charliermarsh/ruff/pull/4685) - Flag empty strings in flake8-errmsg rules by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4745](https://togithub.com/charliermarsh/ruff/pull/4745) - Exclude function definition from too-many-statements rule by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4794](https://togithub.com/charliermarsh/ruff/pull/4794) - Preserve quotes in F523 fixer by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4836](https://togithub.com/charliermarsh/ruff/pull/4836) - Fix round-tripping of nested functions by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4875](https://togithub.com/charliermarsh/ruff/pull/4875) - Avoid early-exit in explicit-f-string-type-conversion by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4886](https://togithub.com/charliermarsh/ruff/pull/4886) - Avoid no-op fix for nested with expressions by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4906](https://togithub.com/charliermarsh/ruff/pull/4906) - Fix UP036 auto-fix error by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [https://github.com/charliermarsh/ruff/pull/4679](https://togithub.com/charliermarsh/ruff/pull/4679) - Use class name as range for `B024` by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4647](https://togithub.com/charliermarsh/ruff/pull/4647) - Change TODO directive detection to work with multiple pound signs on the same line by [@​evanrittenhouse](https://togithub.com/evanrittenhouse) in [https://github.com/charliermarsh/ruff/pull/4558](https://togithub.com/charliermarsh/ruff/pull/4558) - Allow more immutable funcs for RUF009 by [@​qdegraaf](https://togithub.com/qdegraaf) in [https://github.com/charliermarsh/ruff/pull/4660](https://togithub.com/charliermarsh/ruff/pull/4660) - Avoid using typing-imported symbols for runtime edits by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4649](https://togithub.com/charliermarsh/ruff/pull/4649) - Fix `async for` formatting by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4675](https://togithub.com/charliermarsh/ruff/pull/4675) - Ignore **setattr** in FBT003 by [@​alexfikl](https://togithub.com/alexfikl) in [https://github.com/charliermarsh/ruff/pull/4752](https://togithub.com/charliermarsh/ruff/pull/4752) - Include ImportError in non-fixable try-catch imports by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4793](https://togithub.com/charliermarsh/ruff/pull/4793) - Avoid extra newline between diagnostics in grouped mode by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4776](https://togithub.com/charliermarsh/ruff/pull/4776) - Avoid enforcing native-literals rule within nested f-strings by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4488](https://togithub.com/charliermarsh/ruff/pull/4488) - Respect mixed variable assignment in RET504 by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4835](https://togithub.com/charliermarsh/ruff/pull/4835) - Make FLY002 autofix into a constant string instead of an f-string if all `join()` arguments are strings by [@​evanrittenhouse](https://togithub.com/evanrittenhouse) in [https://github.com/charliermarsh/ruff/pull/4834](https://togithub.com/charliermarsh/ruff/pull/4834) - Add some exceptions for FBT003 ([#​3247](https://togithub.com/charliermarsh/ruff/issues/3247)) by [@​allisonkarlitskaya](https://togithub.com/allisonkarlitskaya) in [https://github.com/charliermarsh/ruff/pull/4867](https://togithub.com/charliermarsh/ruff/pull/4867) - Avoid running RUF100 rules when code contains syntax errors by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4869](https://togithub.com/charliermarsh/ruff/pull/4869) - Avoid index-out-of-bands panic for positional placeholders by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4872](https://togithub.com/charliermarsh/ruff/pull/4872) - Remove destructive fixes for F523 by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4883](https://togithub.com/charliermarsh/ruff/pull/4883) - Respect shadowed exports in `__all__` by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4885](https://togithub.com/charliermarsh/ruff/pull/4885) - Track symbol deletions separately from bindings by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4888](https://togithub.com/charliermarsh/ruff/pull/4888) - Change fixable_set to include RuleSelector::All/Nursery by [@​evanrittenhouse](https://togithub.com/evanrittenhouse) in [https://github.com/charliermarsh/ruff/pull/4852](https://togithub.com/charliermarsh/ruff/pull/4852) #### New Contributors - [@​bersbersbers](https://togithub.com/bersbersbers) made their first contribution in [https://github.com/charliermarsh/ruff/pull/4644](https://togithub.com/charliermarsh/ruff/pull/4644) - [@​jlaneve](https://togithub.com/jlaneve) made their first contribution in [https://github.com/charliermarsh/ruff/pull/4690](https://togithub.com/charliermarsh/ruff/pull/4690) - [@​suharnikov](https://togithub.com/suharnikov) made their first contribution in [https://github.com/charliermarsh/ruff/pull/4678](https://togithub.com/charliermarsh/ruff/pull/4678) - [@​alexfikl](https://togithub.com/alexfikl) made their first contribution in [https://github.com/charliermarsh/ruff/pull/4752](https://togithub.com/charliermarsh/ruff/pull/4752) - [@​allisonkarlitskaya](https://togithub.com/allisonkarlitskaya) made their first contribution in [https://github.com/charliermarsh/ruff/pull/4867](https://togithub.com/charliermarsh/ruff/pull/4867) - [@​Ryang20718](https://togithub.com/Ryang20718) made their first contribution in [https://github.com/charliermarsh/ruff/pull/4854](https://togithub.com/charliermarsh/ruff/pull/4854) - [@​addisoncrump](https://togithub.com/addisoncrump) made their first contribution in [https://github.com/charliermarsh/ruff/pull/4893](https://togithub.com/charliermarsh/ruff/pull/4893) **Full Changelog**: astral-sh/ruff@v0.0.270...v0.0.271 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/ixm-one/pytest-cmake-presets). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMTAuMCIsInVwZGF0ZWRJblZlciI6IjM1LjExMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
jankatins
referenced
this pull request
in jankatins/pr-workflow-example
Jun 8, 2023
](https://renovatebot.com){kind=link}
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://togithub.com/charliermarsh/ruff) ([changelog](https://togithub.com/charliermarsh/ruff/releases)) | `0.0.270` -> `0.0.272` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>charliermarsh/ruff</summary> ### [`v0.0.272`](https://togithub.com/astral-sh/ruff/releases/tag/v0.0.272) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.271...v0.0.272) <!-- Release notes generated using configuration in .github/release.yml at main --> #### What's Changed ##### Breaking Changes - Move flake8-fixme rules to FIX prefix by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4917](https://togithub.com/charliermarsh/ruff/pull/4917) ##### Rules - \[`flake8-pyi`] Implement PYI050 by [@​density](https://togithub.com/density) in [https://github.com/charliermarsh/ruff/pull/4884](https://togithub.com/charliermarsh/ruff/pull/4884) ##### Bug Fixes - Avoid attributing runtime references to module-level imports by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4942](https://togithub.com/charliermarsh/ruff/pull/4942) - Skip class scopes when resolving nonlocal references by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4943](https://togithub.com/charliermarsh/ruff/pull/4943) - Apply `dict.get` fix before ternary rewrite by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4944](https://togithub.com/charliermarsh/ruff/pull/4944) - Handle implicit string concatenations in conversion-flag rewrites by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4947](https://togithub.com/charliermarsh/ruff/pull/4947) - Make `C413` fix as suggested for `reversed` call by [@​dhruvmanila](https://togithub.com/dhruvmanila) in [https://github.com/charliermarsh/ruff/pull/4891](https://togithub.com/charliermarsh/ruff/pull/4891) - ignore if using infinite iterators in `B905` by [@​kyoto7250](https://togithub.com/kyoto7250) in [https://github.com/charliermarsh/ruff/pull/4914](https://togithub.com/charliermarsh/ruff/pull/4914) **Full Changelog**: astral-sh/ruff@v0.0.271...v0.0.272 ### [`v0.0.271`](https://togithub.com/astral-sh/ruff/releases/tag/v0.0.271) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.270...v0.0.271) <!-- Release notes generated using configuration in .github/release.yml at main --> #### What's Changed ##### Rules - Add autofix for flake8-type-checking by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4742](https://togithub.com/charliermarsh/ruff/pull/4742) - \[`airflow`] Add AIR001: task variable name should be same as task_id arg by [@​jlaneve](https://togithub.com/jlaneve) in [https://github.com/charliermarsh/ruff/pull/4687](https://togithub.com/charliermarsh/ruff/pull/4687) - \[`flake8-bandit`] Implement S609, linux_commands_wildcard_injection by [@​scop](https://togithub.com/scop) in [https://github.com/charliermarsh/ruff/pull/4504](https://togithub.com/charliermarsh/ruff/pull/4504) - \[`flake8-bugbear`] Move duplicate-value rule to flake8-bugbear by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4882](https://togithub.com/charliermarsh/ruff/pull/4882) - \[`flake8-fixme`] Implement `flake8_fixme` and refactor `TodoDirective` by [@​evanrittenhouse](https://togithub.com/evanrittenhouse) in [https://github.com/charliermarsh/ruff/pull/4681](https://togithub.com/charliermarsh/ruff/pull/4681) - \[`flake8-future-annotations`] Implement `FA102` by [@​akx](https://togithub.com/akx) in [https://github.com/charliermarsh/ruff/pull/4702](https://togithub.com/charliermarsh/ruff/pull/4702) - \[`flake8-pyi`] Add PYI024 for `flake8-pyi` plugin by [@​qdegraaf](https://togithub.com/qdegraaf) in [https://github.com/charliermarsh/ruff/pull/4756](https://togithub.com/charliermarsh/ruff/pull/4756) - \[`flake8-pyi`] Add PYI034 for `flake8-pyi` plugin by [@​qdegraaf](https://togithub.com/qdegraaf) in [https://github.com/charliermarsh/ruff/pull/4764](https://togithub.com/charliermarsh/ruff/pull/4764) - \[`flake8-pyi`] Add `PYI032` rule with autofix by [@​qdegraaf](https://togithub.com/qdegraaf) in [https://github.com/charliermarsh/ruff/pull/4695](https://togithub.com/charliermarsh/ruff/pull/4695) - \[`flake8-pyi`] Add autofix for PYI010 by [@​qdegraaf](https://togithub.com/qdegraaf) in [https://github.com/charliermarsh/ruff/pull/4634](https://togithub.com/charliermarsh/ruff/pull/4634) - \[`flake8-pyi`] Implement PYI029 by [@​density](https://togithub.com/density) in [https://github.com/charliermarsh/ruff/pull/4851](https://togithub.com/charliermarsh/ruff/pull/4851) - \[`flake8-pyi`] Implement PYI035 by [@​density](https://togithub.com/density) in [https://github.com/charliermarsh/ruff/pull/4820](https://togithub.com/charliermarsh/ruff/pull/4820) - \[`flake8-pyi`] Implement PYI048 for `flake8-pyi` plugin by [@​qdegraaf](https://togithub.com/qdegraaf) in [https://github.com/charliermarsh/ruff/pull/4645](https://togithub.com/charliermarsh/ruff/pull/4645) - \[`flake8-pyi`] Implement PYI053 by [@​density](https://togithub.com/density) in [https://github.com/charliermarsh/ruff/pull/4770](https://togithub.com/charliermarsh/ruff/pull/4770) - \[`flake8-pyi`] Implement PYI054 by [@​density](https://togithub.com/density) in [https://github.com/charliermarsh/ruff/pull/4775](https://togithub.com/charliermarsh/ruff/pull/4775) - \[`flake8-pyi`] Implement `PYI025` by [@​qdegraaf](https://togithub.com/qdegraaf) in [https://github.com/charliermarsh/ruff/pull/4791](https://togithub.com/charliermarsh/ruff/pull/4791) - \[`flake8-pyi`] Implement `PYI045` by [@​density](https://togithub.com/density) in [https://github.com/charliermarsh/ruff/pull/4700](https://togithub.com/charliermarsh/ruff/pull/4700) - \[`pylint`] Add Pylint rule `C0208` (`use-sequence-for-iteration`) as `PLC0208` (`iteration-over-set`) by [@​tjkuson](https://togithub.com/tjkuson) in [https://github.com/charliermarsh/ruff/pull/4706](https://togithub.com/charliermarsh/ruff/pull/4706) - \[`pylint`] Add autofix for `PLR1701` (repeated-isinstance-calls) by [@​dhruvmanila](https://togithub.com/dhruvmanila) in [https://github.com/charliermarsh/ruff/pull/4792](https://togithub.com/charliermarsh/ruff/pull/4792) - \[`pylint`] Implement Pylint's `yield-inside-async-function` rule (`PLE1700`) by [@​chanman3388](https://togithub.com/chanman3388) in [https://github.com/charliermarsh/ruff/pull/4668](https://togithub.com/charliermarsh/ruff/pull/4668) - \[`pylint`] implement E307 for pylint invalid str return type by [@​Ryang20718](https://togithub.com/Ryang20718) in [https://github.com/charliermarsh/ruff/pull/4854](https://togithub.com/charliermarsh/ruff/pull/4854) - \[`ruff`] Lint pyproject.toml by [@​konstin](https://togithub.com/konstin) in [https://github.com/charliermarsh/ruff/pull/4496](https://togithub.com/charliermarsh/ruff/pull/4496) - \[`tryceratops`] Ignore error calls with `exc_info` in TRY400 by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4797](https://togithub.com/charliermarsh/ruff/pull/4797) ##### Settings - Add `pyflakes.extend-generics` setting by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [https://github.com/charliermarsh/ruff/pull/4677](https://togithub.com/charliermarsh/ruff/pull/4677) ##### Bug Fixes - Fix PLW3301 false positive single argument nested min/max by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [https://github.com/charliermarsh/ruff/pull/4683](https://togithub.com/charliermarsh/ruff/pull/4683) - Handle dotted alias imports to check for implicit imports by [@​dhruvmanila](https://togithub.com/dhruvmanila) in [https://github.com/charliermarsh/ruff/pull/4685](https://togithub.com/charliermarsh/ruff/pull/4685) - Flag empty strings in flake8-errmsg rules by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4745](https://togithub.com/charliermarsh/ruff/pull/4745) - Exclude function definition from too-many-statements rule by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4794](https://togithub.com/charliermarsh/ruff/pull/4794) - Preserve quotes in F523 fixer by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4836](https://togithub.com/charliermarsh/ruff/pull/4836) - Fix round-tripping of nested functions by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4875](https://togithub.com/charliermarsh/ruff/pull/4875) - Avoid early-exit in explicit-f-string-type-conversion by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4886](https://togithub.com/charliermarsh/ruff/pull/4886) - Avoid no-op fix for nested with expressions by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4906](https://togithub.com/charliermarsh/ruff/pull/4906) - Fix UP036 auto-fix error by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [https://github.com/charliermarsh/ruff/pull/4679](https://togithub.com/charliermarsh/ruff/pull/4679) - Use class name as range for `B024` by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4647](https://togithub.com/charliermarsh/ruff/pull/4647) - Change TODO directive detection to work with multiple pound signs on the same line by [@​evanrittenhouse](https://togithub.com/evanrittenhouse) in [https://github.com/charliermarsh/ruff/pull/4558](https://togithub.com/charliermarsh/ruff/pull/4558) - Allow more immutable funcs for RUF009 by [@​qdegraaf](https://togithub.com/qdegraaf) in [https://github.com/charliermarsh/ruff/pull/4660](https://togithub.com/charliermarsh/ruff/pull/4660) - Avoid using typing-imported symbols for runtime edits by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4649](https://togithub.com/charliermarsh/ruff/pull/4649) - Fix `async for` formatting by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4675](https://togithub.com/charliermarsh/ruff/pull/4675) - Ignore **setattr** in FBT003 by [@​alexfikl](https://togithub.com/alexfikl) in [https://github.com/charliermarsh/ruff/pull/4752](https://togithub.com/charliermarsh/ruff/pull/4752) - Include ImportError in non-fixable try-catch imports by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4793](https://togithub.com/charliermarsh/ruff/pull/4793) - Avoid extra newline between diagnostics in grouped mode by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4776](https://togithub.com/charliermarsh/ruff/pull/4776) - Avoid enforcing native-literals rule within nested f-strings by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4488](https://togithub.com/charliermarsh/ruff/pull/4488) - Respect mixed variable assignment in RET504 by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4835](https://togithub.com/charliermarsh/ruff/pull/4835) - Make FLY002 autofix into a constant string instead of an f-string if all `join()` arguments are strings by [@​evanrittenhouse](https://togithub.com/evanrittenhouse) in [https://github.com/charliermarsh/ruff/pull/4834](https://togithub.com/charliermarsh/ruff/pull/4834) - Add some exceptions for FBT003 ([#​3247](https://togithub.com/charliermarsh/ruff/issues/3247)) by [@​allisonkarlitskaya](https://togithub.com/allisonkarlitskaya) in [https://github.com/charliermarsh/ruff/pull/4867](https://togithub.com/charliermarsh/ruff/pull/4867) - Avoid running RUF100 rules when code contains syntax errors by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4869](https://togithub.com/charliermarsh/ruff/pull/4869) - Avoid index-out-of-bands panic for positional placeholders by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4872](https://togithub.com/charliermarsh/ruff/pull/4872) - Remove destructive fixes for F523 by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4883](https://togithub.com/charliermarsh/ruff/pull/4883) - Respect shadowed exports in `__all__` by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4885](https://togithub.com/charliermarsh/ruff/pull/4885) - Track symbol deletions separately from bindings by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4888](https://togithub.com/charliermarsh/ruff/pull/4888) - Change fixable_set to include RuleSelector::All/Nursery by [@​evanrittenhouse](https://togithub.com/evanrittenhouse) in [https://github.com/charliermarsh/ruff/pull/4852](https://togithub.com/charliermarsh/ruff/pull/4852) #### New Contributors - [@​bersbersbers](https://togithub.com/bersbersbers) made their first contribution in [https://github.com/charliermarsh/ruff/pull/4644](https://togithub.com/charliermarsh/ruff/pull/4644) - [@​jlaneve](https://togithub.com/jlaneve) made their first contribution in [https://github.com/charliermarsh/ruff/pull/4690](https://togithub.com/charliermarsh/ruff/pull/4690) - [@​suharnikov](https://togithub.com/suharnikov) made their first contribution in [https://github.com/charliermarsh/ruff/pull/4678](https://togithub.com/charliermarsh/ruff/pull/4678) - [@​alexfikl](https://togithub.com/alexfikl) made their first contribution in [https://github.com/charliermarsh/ruff/pull/4752](https://togithub.com/charliermarsh/ruff/pull/4752) - [@​allisonkarlitskaya](https://togithub.com/allisonkarlitskaya) made their first contribution in [https://github.com/charliermarsh/ruff/pull/4867](https://togithub.com/charliermarsh/ruff/pull/4867) - [@​Ryang20718](https://togithub.com/Ryang20718) made their first contribution in [https://github.com/charliermarsh/ruff/pull/4854](https://togithub.com/charliermarsh/ruff/pull/4854) - [@​addisoncrump](https://togithub.com/addisoncrump) made their first contribution in [https://github.com/charliermarsh/ruff/pull/4893](https://togithub.com/charliermarsh/ruff/pull/4893) **Full Changelog**: astral-sh/ruff@v0.0.270...v0.0.271 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/jankatins/pr-workflow-example). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMTAuMCIsInVwZGF0ZWRJblZlciI6IjM1LjExMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
renovate bot
referenced
this pull request
in allenporter/flux-local
Jun 10, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://togithub.com/charliermarsh/ruff) ([changelog](https://togithub.com/charliermarsh/ruff/releases)) | `==0.0.270` -> `==0.0.272` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>charliermarsh/ruff</summary> ### [`v0.0.272`](https://togithub.com/astral-sh/ruff/releases/tag/v0.0.272) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.271...v0.0.272) <!-- Release notes generated using configuration in .github/release.yml at main --> #### What's Changed ##### Breaking Changes - Move flake8-fixme rules to FIX prefix by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4917](https://togithub.com/charliermarsh/ruff/pull/4917) ##### Rules - \[`flake8-pyi`] Implement PYI050 by [@​density](https://togithub.com/density) in [https://github.com/charliermarsh/ruff/pull/4884](https://togithub.com/charliermarsh/ruff/pull/4884) ##### Bug Fixes - Avoid attributing runtime references to module-level imports by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4942](https://togithub.com/charliermarsh/ruff/pull/4942) - Skip class scopes when resolving nonlocal references by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4943](https://togithub.com/charliermarsh/ruff/pull/4943) - Apply `dict.get` fix before ternary rewrite by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4944](https://togithub.com/charliermarsh/ruff/pull/4944) - Handle implicit string concatenations in conversion-flag rewrites by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4947](https://togithub.com/charliermarsh/ruff/pull/4947) - Make `C413` fix as suggested for `reversed` call by [@​dhruvmanila](https://togithub.com/dhruvmanila) in [https://github.com/charliermarsh/ruff/pull/4891](https://togithub.com/charliermarsh/ruff/pull/4891) - ignore if using infinite iterators in `B905` by [@​kyoto7250](https://togithub.com/kyoto7250) in [https://github.com/charliermarsh/ruff/pull/4914](https://togithub.com/charliermarsh/ruff/pull/4914) **Full Changelog**: astral-sh/ruff@v0.0.271...v0.0.272 ### [`v0.0.271`](https://togithub.com/astral-sh/ruff/releases/tag/v0.0.271) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.270...v0.0.271) <!-- Release notes generated using configuration in .github/release.yml at main --> #### What's Changed ##### Rules - Add autofix for flake8-type-checking by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4742](https://togithub.com/charliermarsh/ruff/pull/4742) - \[`airflow`] Add AIR001: task variable name should be same as task_id arg by [@​jlaneve](https://togithub.com/jlaneve) in [https://github.com/charliermarsh/ruff/pull/4687](https://togithub.com/charliermarsh/ruff/pull/4687) - \[`flake8-bandit`] Implement S609, linux_commands_wildcard_injection by [@​scop](https://togithub.com/scop) in [https://github.com/charliermarsh/ruff/pull/4504](https://togithub.com/charliermarsh/ruff/pull/4504) - \[`flake8-bugbear`] Move duplicate-value rule to flake8-bugbear by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4882](https://togithub.com/charliermarsh/ruff/pull/4882) - \[`flake8-fixme`] Implement `flake8_fixme` and refactor `TodoDirective` by [@​evanrittenhouse](https://togithub.com/evanrittenhouse) in [https://github.com/charliermarsh/ruff/pull/4681](https://togithub.com/charliermarsh/ruff/pull/4681) - \[`flake8-future-annotations`] Implement `FA102` by [@​akx](https://togithub.com/akx) in [https://github.com/charliermarsh/ruff/pull/4702](https://togithub.com/charliermarsh/ruff/pull/4702) - \[`flake8-pyi`] Add PYI024 for `flake8-pyi` plugin by [@​qdegraaf](https://togithub.com/qdegraaf) in [https://github.com/charliermarsh/ruff/pull/4756](https://togithub.com/charliermarsh/ruff/pull/4756) - \[`flake8-pyi`] Add PYI034 for `flake8-pyi` plugin by [@​qdegraaf](https://togithub.com/qdegraaf) in [https://github.com/charliermarsh/ruff/pull/4764](https://togithub.com/charliermarsh/ruff/pull/4764) - \[`flake8-pyi`] Add `PYI032` rule with autofix by [@​qdegraaf](https://togithub.com/qdegraaf) in [https://github.com/charliermarsh/ruff/pull/4695](https://togithub.com/charliermarsh/ruff/pull/4695) - \[`flake8-pyi`] Add autofix for PYI010 by [@​qdegraaf](https://togithub.com/qdegraaf) in [https://github.com/charliermarsh/ruff/pull/4634](https://togithub.com/charliermarsh/ruff/pull/4634) - \[`flake8-pyi`] Implement PYI029 by [@​density](https://togithub.com/density) in [https://github.com/charliermarsh/ruff/pull/4851](https://togithub.com/charliermarsh/ruff/pull/4851) - \[`flake8-pyi`] Implement PYI035 by [@​density](https://togithub.com/density) in [https://github.com/charliermarsh/ruff/pull/4820](https://togithub.com/charliermarsh/ruff/pull/4820) - \[`flake8-pyi`] Implement PYI048 for `flake8-pyi` plugin by [@​qdegraaf](https://togithub.com/qdegraaf) in [https://github.com/charliermarsh/ruff/pull/4645](https://togithub.com/charliermarsh/ruff/pull/4645) - \[`flake8-pyi`] Implement PYI053 by [@​density](https://togithub.com/density) in [https://github.com/charliermarsh/ruff/pull/4770](https://togithub.com/charliermarsh/ruff/pull/4770) - \[`flake8-pyi`] Implement PYI054 by [@​density](https://togithub.com/density) in [https://github.com/charliermarsh/ruff/pull/4775](https://togithub.com/charliermarsh/ruff/pull/4775) - \[`flake8-pyi`] Implement `PYI025` by [@​qdegraaf](https://togithub.com/qdegraaf) in [https://github.com/charliermarsh/ruff/pull/4791](https://togithub.com/charliermarsh/ruff/pull/4791) - \[`flake8-pyi`] Implement `PYI045` by [@​density](https://togithub.com/density) in [https://github.com/charliermarsh/ruff/pull/4700](https://togithub.com/charliermarsh/ruff/pull/4700) - \[`pylint`] Add Pylint rule `C0208` (`use-sequence-for-iteration`) as `PLC0208` (`iteration-over-set`) by [@​tjkuson](https://togithub.com/tjkuson) in [https://github.com/charliermarsh/ruff/pull/4706](https://togithub.com/charliermarsh/ruff/pull/4706) - \[`pylint`] Add autofix for `PLR1701` (repeated-isinstance-calls) by [@​dhruvmanila](https://togithub.com/dhruvmanila) in [https://github.com/charliermarsh/ruff/pull/4792](https://togithub.com/charliermarsh/ruff/pull/4792) - \[`pylint`] Implement Pylint's `yield-inside-async-function` rule (`PLE1700`) by [@​chanman3388](https://togithub.com/chanman3388) in [https://github.com/charliermarsh/ruff/pull/4668](https://togithub.com/charliermarsh/ruff/pull/4668) - \[`pylint`] implement E307 for pylint invalid str return type by [@​Ryang20718](https://togithub.com/Ryang20718) in [https://github.com/charliermarsh/ruff/pull/4854](https://togithub.com/charliermarsh/ruff/pull/4854) - \[`ruff`] Lint pyproject.toml by [@​konstin](https://togithub.com/konstin) in [https://github.com/charliermarsh/ruff/pull/4496](https://togithub.com/charliermarsh/ruff/pull/4496) - \[`tryceratops`] Ignore error calls with `exc_info` in TRY400 by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4797](https://togithub.com/charliermarsh/ruff/pull/4797) ##### Settings - Add `pyflakes.extend-generics` setting by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [https://github.com/charliermarsh/ruff/pull/4677](https://togithub.com/charliermarsh/ruff/pull/4677) ##### Bug Fixes - Fix PLW3301 false positive single argument nested min/max by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [https://github.com/charliermarsh/ruff/pull/4683](https://togithub.com/charliermarsh/ruff/pull/4683) - Handle dotted alias imports to check for implicit imports by [@​dhruvmanila](https://togithub.com/dhruvmanila) in [https://github.com/charliermarsh/ruff/pull/4685](https://togithub.com/charliermarsh/ruff/pull/4685) - Flag empty strings in flake8-errmsg rules by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4745](https://togithub.com/charliermarsh/ruff/pull/4745) - Exclude function definition from too-many-statements rule by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4794](https://togithub.com/charliermarsh/ruff/pull/4794) - Preserve quotes in F523 fixer by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4836](https://togithub.com/charliermarsh/ruff/pull/4836) - Fix round-tripping of nested functions by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4875](https://togithub.com/charliermarsh/ruff/pull/4875) - Avoid early-exit in explicit-f-string-type-conversion by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4886](https://togithub.com/charliermarsh/ruff/pull/4886) - Avoid no-op fix for nested with expressions by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4906](https://togithub.com/charliermarsh/ruff/pull/4906) - Fix UP036 auto-fix error by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [https://github.com/charliermarsh/ruff/pull/4679](https://togithub.com/charliermarsh/ruff/pull/4679) - Use class name as range for `B024` by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4647](https://togithub.com/charliermarsh/ruff/pull/4647) - Change TODO directive detection to work with multiple pound signs on the same line by [@​evanrittenhouse](https://togithub.com/evanrittenhouse) in [https://github.com/charliermarsh/ruff/pull/4558](https://togithub.com/charliermarsh/ruff/pull/4558) - Allow more immutable funcs for RUF009 by [@​qdegraaf](https://togithub.com/qdegraaf) in [https://github.com/charliermarsh/ruff/pull/4660](https://togithub.com/charliermarsh/ruff/pull/4660) - Avoid using typing-imported symbols for runtime edits by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4649](https://togithub.com/charliermarsh/ruff/pull/4649) - Fix `async for` formatting by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4675](https://togithub.com/charliermarsh/ruff/pull/4675) - Ignore **setattr** in FBT003 by [@​alexfikl](https://togithub.com/alexfikl) in [https://github.com/charliermarsh/ruff/pull/4752](https://togithub.com/charliermarsh/ruff/pull/4752) - Include ImportError in non-fixable try-catch imports by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4793](https://togithub.com/charliermarsh/ruff/pull/4793) - Avoid extra newline between diagnostics in grouped mode by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4776](https://togithub.com/charliermarsh/ruff/pull/4776) - Avoid enforcing native-literals rule within nested f-strings by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4488](https://togithub.com/charliermarsh/ruff/pull/4488) - Respect mixed variable assignment in RET504 by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4835](https://togithub.com/charliermarsh/ruff/pull/4835) - Make FLY002 autofix into a constant string instead of an f-string if all `join()` arguments are strings by [@​evanrittenhouse](https://togithub.com/evanrittenhouse) in [https://github.com/charliermarsh/ruff/pull/4834](https://togithub.com/charliermarsh/ruff/pull/4834) - Add some exceptions for FBT003 ([#​3247](https://togithub.com/charliermarsh/ruff/issues/3247)) by [@​allisonkarlitskaya](https://togithub.com/allisonkarlitskaya) in [https://github.com/charliermarsh/ruff/pull/4867](https://togithub.com/charliermarsh/ruff/pull/4867) - Avoid running RUF100 rules when code contains syntax errors by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4869](https://togithub.com/charliermarsh/ruff/pull/4869) - Avoid index-out-of-bands panic for positional placeholders by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4872](https://togithub.com/charliermarsh/ruff/pull/4872) - Remove destructive fixes for F523 by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4883](https://togithub.com/charliermarsh/ruff/pull/4883) - Respect shadowed exports in `__all__` by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4885](https://togithub.com/charliermarsh/ruff/pull/4885) - Track symbol deletions separately from bindings by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4888](https://togithub.com/charliermarsh/ruff/pull/4888) - Change fixable_set to include RuleSelector::All/Nursery by [@​evanrittenhouse](https://togithub.com/evanrittenhouse) in [https://github.com/charliermarsh/ruff/pull/4852](https://togithub.com/charliermarsh/ruff/pull/4852) #### New Contributors - [@​bersbersbers](https://togithub.com/bersbersbers) made their first contribution in [https://github.com/charliermarsh/ruff/pull/4644](https://togithub.com/charliermarsh/ruff/pull/4644) - [@​jlaneve](https://togithub.com/jlaneve) made their first contribution in [https://github.com/charliermarsh/ruff/pull/4690](https://togithub.com/charliermarsh/ruff/pull/4690) - [@​suharnikov](https://togithub.com/suharnikov) made their first contribution in [https://github.com/charliermarsh/ruff/pull/4678](https://togithub.com/charliermarsh/ruff/pull/4678) - [@​alexfikl](https://togithub.com/alexfikl) made their first contribution in [https://github.com/charliermarsh/ruff/pull/4752](https://togithub.com/charliermarsh/ruff/pull/4752) - [@​allisonkarlitskaya](https://togithub.com/allisonkarlitskaya) made their first contribution in [https://github.com/charliermarsh/ruff/pull/4867](https://togithub.com/charliermarsh/ruff/pull/4867) - [@​Ryang20718](https://togithub.com/Ryang20718) made their first contribution in [https://github.com/charliermarsh/ruff/pull/4854](https://togithub.com/charliermarsh/ruff/pull/4854) - [@​addisoncrump](https://togithub.com/addisoncrump) made their first contribution in [https://github.com/charliermarsh/ruff/pull/4893](https://togithub.com/charliermarsh/ruff/pull/4893) **Full Changelog**: astral-sh/ruff@v0.0.270...v0.0.271 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/allenporter/flux-local). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMTAuMCIsInVwZGF0ZWRJblZlciI6IjM1LjExMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot
referenced
this pull request
in allenporter/pyrainbird
Jun 10, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://togithub.com/charliermarsh/ruff) ([changelog](https://togithub.com/charliermarsh/ruff/releases)) | `==0.0.270` -> `==0.0.272` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>charliermarsh/ruff</summary> ### [`v0.0.272`](https://togithub.com/astral-sh/ruff/releases/tag/v0.0.272) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.271...v0.0.272) <!-- Release notes generated using configuration in .github/release.yml at main --> #### What's Changed ##### Breaking Changes - Move flake8-fixme rules to FIX prefix by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4917](https://togithub.com/charliermarsh/ruff/pull/4917) ##### Rules - \[`flake8-pyi`] Implement PYI050 by [@​density](https://togithub.com/density) in [https://github.com/charliermarsh/ruff/pull/4884](https://togithub.com/charliermarsh/ruff/pull/4884) ##### Bug Fixes - Avoid attributing runtime references to module-level imports by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4942](https://togithub.com/charliermarsh/ruff/pull/4942) - Skip class scopes when resolving nonlocal references by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4943](https://togithub.com/charliermarsh/ruff/pull/4943) - Apply `dict.get` fix before ternary rewrite by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4944](https://togithub.com/charliermarsh/ruff/pull/4944) - Handle implicit string concatenations in conversion-flag rewrites by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4947](https://togithub.com/charliermarsh/ruff/pull/4947) - Make `C413` fix as suggested for `reversed` call by [@​dhruvmanila](https://togithub.com/dhruvmanila) in [https://github.com/charliermarsh/ruff/pull/4891](https://togithub.com/charliermarsh/ruff/pull/4891) - ignore if using infinite iterators in `B905` by [@​kyoto7250](https://togithub.com/kyoto7250) in [https://github.com/charliermarsh/ruff/pull/4914](https://togithub.com/charliermarsh/ruff/pull/4914) **Full Changelog**: astral-sh/ruff@v0.0.271...v0.0.272 ### [`v0.0.271`](https://togithub.com/astral-sh/ruff/releases/tag/v0.0.271) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.270...v0.0.271) <!-- Release notes generated using configuration in .github/release.yml at main --> #### What's Changed ##### Rules - Add autofix for flake8-type-checking by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4742](https://togithub.com/charliermarsh/ruff/pull/4742) - \[`airflow`] Add AIR001: task variable name should be same as task_id arg by [@​jlaneve](https://togithub.com/jlaneve) in [https://github.com/charliermarsh/ruff/pull/4687](https://togithub.com/charliermarsh/ruff/pull/4687) - \[`flake8-bandit`] Implement S609, linux_commands_wildcard_injection by [@​scop](https://togithub.com/scop) in [https://github.com/charliermarsh/ruff/pull/4504](https://togithub.com/charliermarsh/ruff/pull/4504) - \[`flake8-bugbear`] Move duplicate-value rule to flake8-bugbear by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4882](https://togithub.com/charliermarsh/ruff/pull/4882) - \[`flake8-fixme`] Implement `flake8_fixme` and refactor `TodoDirective` by [@​evanrittenhouse](https://togithub.com/evanrittenhouse) in [https://github.com/charliermarsh/ruff/pull/4681](https://togithub.com/charliermarsh/ruff/pull/4681) - \[`flake8-future-annotations`] Implement `FA102` by [@​akx](https://togithub.com/akx) in [https://github.com/charliermarsh/ruff/pull/4702](https://togithub.com/charliermarsh/ruff/pull/4702) - \[`flake8-pyi`] Add PYI024 for `flake8-pyi` plugin by [@​qdegraaf](https://togithub.com/qdegraaf) in [https://github.com/charliermarsh/ruff/pull/4756](https://togithub.com/charliermarsh/ruff/pull/4756) - \[`flake8-pyi`] Add PYI034 for `flake8-pyi` plugin by [@​qdegraaf](https://togithub.com/qdegraaf) in [https://github.com/charliermarsh/ruff/pull/4764](https://togithub.com/charliermarsh/ruff/pull/4764) - \[`flake8-pyi`] Add `PYI032` rule with autofix by [@​qdegraaf](https://togithub.com/qdegraaf) in [https://github.com/charliermarsh/ruff/pull/4695](https://togithub.com/charliermarsh/ruff/pull/4695) - \[`flake8-pyi`] Add autofix for PYI010 by [@​qdegraaf](https://togithub.com/qdegraaf) in [https://github.com/charliermarsh/ruff/pull/4634](https://togithub.com/charliermarsh/ruff/pull/4634) - \[`flake8-pyi`] Implement PYI029 by [@​density](https://togithub.com/density) in [https://github.com/charliermarsh/ruff/pull/4851](https://togithub.com/charliermarsh/ruff/pull/4851) - \[`flake8-pyi`] Implement PYI035 by [@​density](https://togithub.com/density) in [https://github.com/charliermarsh/ruff/pull/4820](https://togithub.com/charliermarsh/ruff/pull/4820) - \[`flake8-pyi`] Implement PYI048 for `flake8-pyi` plugin by [@​qdegraaf](https://togithub.com/qdegraaf) in [https://github.com/charliermarsh/ruff/pull/4645](https://togithub.com/charliermarsh/ruff/pull/4645) - \[`flake8-pyi`] Implement PYI053 by [@​density](https://togithub.com/density) in [https://github.com/charliermarsh/ruff/pull/4770](https://togithub.com/charliermarsh/ruff/pull/4770) - \[`flake8-pyi`] Implement PYI054 by [@​density](https://togithub.com/density) in [https://github.com/charliermarsh/ruff/pull/4775](https://togithub.com/charliermarsh/ruff/pull/4775) - \[`flake8-pyi`] Implement `PYI025` by [@​qdegraaf](https://togithub.com/qdegraaf) in [https://github.com/charliermarsh/ruff/pull/4791](https://togithub.com/charliermarsh/ruff/pull/4791) - \[`flake8-pyi`] Implement `PYI045` by [@​density](https://togithub.com/density) in [https://github.com/charliermarsh/ruff/pull/4700](https://togithub.com/charliermarsh/ruff/pull/4700) - \[`pylint`] Add Pylint rule `C0208` (`use-sequence-for-iteration`) as `PLC0208` (`iteration-over-set`) by [@​tjkuson](https://togithub.com/tjkuson) in [https://github.com/charliermarsh/ruff/pull/4706](https://togithub.com/charliermarsh/ruff/pull/4706) - \[`pylint`] Add autofix for `PLR1701` (repeated-isinstance-calls) by [@​dhruvmanila](https://togithub.com/dhruvmanila) in [https://github.com/charliermarsh/ruff/pull/4792](https://togithub.com/charliermarsh/ruff/pull/4792) - \[`pylint`] Implement Pylint's `yield-inside-async-function` rule (`PLE1700`) by [@​chanman3388](https://togithub.com/chanman3388) in [https://github.com/charliermarsh/ruff/pull/4668](https://togithub.com/charliermarsh/ruff/pull/4668) - \[`pylint`] implement E307 for pylint invalid str return type by [@​Ryang20718](https://togithub.com/Ryang20718) in [https://github.com/charliermarsh/ruff/pull/4854](https://togithub.com/charliermarsh/ruff/pull/4854) - \[`ruff`] Lint pyproject.toml by [@​konstin](https://togithub.com/konstin) in [https://github.com/charliermarsh/ruff/pull/4496](https://togithub.com/charliermarsh/ruff/pull/4496) - \[`tryceratops`] Ignore error calls with `exc_info` in TRY400 by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4797](https://togithub.com/charliermarsh/ruff/pull/4797) ##### Settings - Add `pyflakes.extend-generics` setting by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [https://github.com/charliermarsh/ruff/pull/4677](https://togithub.com/charliermarsh/ruff/pull/4677) ##### Bug Fixes - Fix PLW3301 false positive single argument nested min/max by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [https://github.com/charliermarsh/ruff/pull/4683](https://togithub.com/charliermarsh/ruff/pull/4683) - Handle dotted alias imports to check for implicit imports by [@​dhruvmanila](https://togithub.com/dhruvmanila) in [https://github.com/charliermarsh/ruff/pull/4685](https://togithub.com/charliermarsh/ruff/pull/4685) - Flag empty strings in flake8-errmsg rules by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4745](https://togithub.com/charliermarsh/ruff/pull/4745) - Exclude function definition from too-many-statements rule by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4794](https://togithub.com/charliermarsh/ruff/pull/4794) - Preserve quotes in F523 fixer by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4836](https://togithub.com/charliermarsh/ruff/pull/4836) - Fix round-tripping of nested functions by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4875](https://togithub.com/charliermarsh/ruff/pull/4875) - Avoid early-exit in explicit-f-string-type-conversion by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4886](https://togithub.com/charliermarsh/ruff/pull/4886) - Avoid no-op fix for nested with expressions by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4906](https://togithub.com/charliermarsh/ruff/pull/4906) - Fix UP036 auto-fix error by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [https://github.com/charliermarsh/ruff/pull/4679](https://togithub.com/charliermarsh/ruff/pull/4679) - Use class name as range for `B024` by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4647](https://togithub.com/charliermarsh/ruff/pull/4647) - Change TODO directive detection to work with multiple pound signs on the same line by [@​evanrittenhouse](https://togithub.com/evanrittenhouse) in [https://github.com/charliermarsh/ruff/pull/4558](https://togithub.com/charliermarsh/ruff/pull/4558) - Allow more immutable funcs for RUF009 by [@​qdegraaf](https://togithub.com/qdegraaf) in [https://github.com/charliermarsh/ruff/pull/4660](https://togithub.com/charliermarsh/ruff/pull/4660) - Avoid using typing-imported symbols for runtime edits by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4649](https://togithub.com/charliermarsh/ruff/pull/4649) - Fix `async for` formatting by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4675](https://togithub.com/charliermarsh/ruff/pull/4675) - Ignore **setattr** in FBT003 by [@​alexfikl](https://togithub.com/alexfikl) in [https://github.com/charliermarsh/ruff/pull/4752](https://togithub.com/charliermarsh/ruff/pull/4752) - Include ImportError in non-fixable try-catch imports by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4793](https://togithub.com/charliermarsh/ruff/pull/4793) - Avoid extra newline between diagnostics in grouped mode by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4776](https://togithub.com/charliermarsh/ruff/pull/4776) - Avoid enforcing native-literals rule within nested f-strings by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4488](https://togithub.com/charliermarsh/ruff/pull/4488) - Respect mixed variable assignment in RET504 by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4835](https://togithub.com/charliermarsh/ruff/pull/4835) - Make FLY002 autofix into a constant string instead of an f-string if all `join()` arguments are strings by [@​evanrittenhouse](https://togithub.com/evanrittenhouse) in [https://github.com/charliermarsh/ruff/pull/4834](https://togithub.com/charliermarsh/ruff/pull/4834) - Add some exceptions for FBT003 ([#​3247](https://togithub.com/charliermarsh/ruff/issues/3247)) by [@​allisonkarlitskaya](https://togithub.com/allisonkarlitskaya) in [https://github.com/charliermarsh/ruff/pull/4867](https://togithub.com/charliermarsh/ruff/pull/4867) - Avoid running RUF100 rules when code contains syntax errors by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4869](https://togithub.com/charliermarsh/ruff/pull/4869) - Avoid index-out-of-bands panic for positional placeholders by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4872](https://togithub.com/charliermarsh/ruff/pull/4872) - Remove destructive fixes for F523 by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4883](https://togithub.com/charliermarsh/ruff/pull/4883) - Respect shadowed exports in `__all__` by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4885](https://togithub.com/charliermarsh/ruff/pull/4885) - Track symbol deletions separately from bindings by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/4888](https://togithub.com/charliermarsh/ruff/pull/4888) - Change fixable_set to include RuleSelector::All/Nursery by [@​evanrittenhouse](https://togithub.com/evanrittenhouse) in [https://github.com/charliermarsh/ruff/pull/4852](https://togithub.com/charliermarsh/ruff/pull/4852) #### New Contributors - [@​bersbersbers](https://togithub.com/bersbersbers) made their first contribution in [https://github.com/charliermarsh/ruff/pull/4644](https://togithub.com/charliermarsh/ruff/pull/4644) - [@​jlaneve](https://togithub.com/jlaneve) made their first contribution in [https://github.com/charliermarsh/ruff/pull/4690](https://togithub.com/charliermarsh/ruff/pull/4690) - [@​suharnikov](https://togithub.com/suharnikov) made their first contribution in [https://github.com/charliermarsh/ruff/pull/4678](https://togithub.com/charliermarsh/ruff/pull/4678) - [@​alexfikl](https://togithub.com/alexfikl) made their first contribution in [https://github.com/charliermarsh/ruff/pull/4752](https://togithub.com/charliermarsh/ruff/pull/4752) - [@​allisonkarlitskaya](https://togithub.com/allisonkarlitskaya) made their first contribution in [https://github.com/charliermarsh/ruff/pull/4867](https://togithub.com/charliermarsh/ruff/pull/4867) - [@​Ryang20718](https://togithub.com/Ryang20718) made their first contribution in [https://github.com/charliermarsh/ruff/pull/4854](https://togithub.com/charliermarsh/ruff/pull/4854) - [@​addisoncrump](https://togithub.com/addisoncrump) made their first contribution in [https://github.com/charliermarsh/ruff/pull/4893](https://togithub.com/charliermarsh/ruff/pull/4893) **Full Changelog**: astral-sh/ruff@v0.0.270...v0.0.271 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/allenporter/pyrainbird). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMTAuMCIsInVwZGF0ZWRJblZlciI6IjM1LjExMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #4549.
Basically, the initial implementation of
flake8-todoshinged on a regex anchoring the#in a Python comment to the start of a line. If no TODO tags were found just after that#, the line would not throw a diagnostic.In the case of something like
# noqa: A003 # TODO: something, the TODO is actually demarcated by a second#. As such, we need to check the characters after each#in the comment in order to findDirectives.