Fix RuleSet.remove

[MichaReiser]

This PR fixes RuleSet.remove(rule) where calling it with a rule that isn't in the set resulted in it being added to the set.

let mut set = RuleSet::default();
set.remove(Rule::AmbiguousFunctionName);

set.contains(AmbiguousFunctionName) // <--- This is now true, but should not

The reason for the bug is that the remove operation uses bitwise XOR rather than and NOT:

	XOR	and NOT
self	00000001	00000001
	XOR	&
other / !other	00100000	11011111
result	000100001	000000001

Fixes #3684

Test plan

I created a input file and configuration as described in #3684 and then ran ruff.

✦2 ❯ cargo run --bin ruff ../test/ --no-cache
    Finished dev [unoptimized + debuginfo] target(s) in 0.11s
     Running `target/debug/ruff ../test/ --no-cache`

Ruff shows no more lint errors.

[MichaReiser]

Current dependencies on/for this PR:

• main
  • PR Fix RuleSet.remove #3685 👈

This comment was auto-generated by Graphite.

[charliermarsh]

Thanks :)

[github-actions]

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

Benchmark

Linux

group                                      main                                   pr
-----                                      ----                                   --
linter/all-rules/large/dataset.py          1.00     13.4±0.03ms     3.0 MB/sec    1.01     13.5±0.04ms     3.0 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      3.6±0.00ms     4.7 MB/sec    1.00      3.6±0.01ms     4.7 MB/sec
linter/all-rules/numpy/globals.py          1.00    495.8±1.32µs     6.0 MB/sec    1.01    499.2±1.48µs     5.9 MB/sec
linter/all-rules/pydantic/types.py         1.00      5.9±0.01ms     4.3 MB/sec    1.00      6.0±0.02ms     4.3 MB/sec
linter/default-rules/large/dataset.py      1.00      7.2±0.03ms     5.7 MB/sec    1.00      7.2±0.02ms     5.7 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00   1619.0±3.16µs    10.3 MB/sec    1.00   1623.5±2.97µs    10.3 MB/sec
linter/default-rules/numpy/globals.py      1.00    182.4±0.66µs    16.2 MB/sec    1.00    183.3±0.89µs    16.1 MB/sec
linter/default-rules/pydantic/types.py     1.00      3.4±0.00ms     7.5 MB/sec    1.00      3.4±0.01ms     7.5 MB/sec

Windows

group                                      main                                   pr
-----                                      ----                                   --
linter/all-rules/large/dataset.py          1.03     20.4±0.58ms  2041.1 KB/sec    1.00     19.9±0.77ms     2.0 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      5.4±0.19ms     3.1 MB/sec    1.00      5.4±0.20ms     3.1 MB/sec
linter/all-rules/numpy/globals.py          1.00   675.6±45.60µs     4.4 MB/sec    1.02   692.4±32.85µs     4.3 MB/sec
linter/all-rules/pydantic/types.py         1.00      8.6±0.34ms     3.0 MB/sec    1.04      9.0±0.44ms     2.8 MB/sec
linter/default-rules/large/dataset.py      1.00     10.8±0.32ms     3.8 MB/sec    1.03     11.1±0.49ms     3.7 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00      2.4±0.08ms     7.1 MB/sec    1.01      2.4±0.10ms     7.0 MB/sec
linter/default-rules/numpy/globals.py      1.00    277.6±9.99µs    10.6 MB/sec    1.04   287.6±14.39µs    10.3 MB/sec
linter/default-rules/pydantic/types.py     1.00      5.0±0.18ms     5.1 MB/sec    1.03      5.1±0.27ms     5.0 MB/sec