-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Move scope and binding types to scope.rs
#3573
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
MichaReiser
force-pushed
the
scope-banding-id
branch
from
March 17, 2023 10:47
ab02e2f
to
919ef5e
Compare
MichaReiser
force-pushed
the
extract-scope
branch
from
March 17, 2023 10:47
79252f3
to
13b3c9a
Compare
MichaReiser
force-pushed
the
scope-banding-id
branch
from
March 17, 2023 10:57
919ef5e
to
e5f64ce
Compare
MichaReiser
force-pushed
the
extract-scope
branch
from
March 17, 2023 10:57
13b3c9a
to
bcc44a3
Compare
MichaReiser
force-pushed
the
extract-scope
branch
2 times, most recently
from
March 17, 2023 11:10
b22b64d
to
e5fa25c
Compare
MichaReiser
force-pushed
the
extract-scope
branch
from
March 17, 2023 11:14
e5fa25c
to
0382b56
Compare
MichaReiser
force-pushed
the
scope-banding-id
branch
from
March 17, 2023 11:18
e5f64ce
to
4550b13
Compare
MichaReiser
force-pushed
the
extract-scope
branch
from
March 17, 2023 11:18
0382b56
to
2755652
Compare
MichaReiser
force-pushed
the
scope-banding-id
branch
from
March 17, 2023 11:27
4550b13
to
f6283e6
Compare
MichaReiser
force-pushed
the
extract-scope
branch
from
March 17, 2023 11:27
2755652
to
420a3b4
Compare
PR Check ResultsEcosystem✅ ecosystem check detected no changes. BenchmarkLinux
Windows
|
MichaReiser
force-pushed
the
extract-scope
branch
from
March 17, 2023 15:49
2403d8e
to
a1bffae
Compare
charliermarsh
approved these changes
Mar 17, 2023
MichaReiser
force-pushed
the
extract-scope
branch
from
March 17, 2023 16:13
a1bffae
to
f46f65a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves all the scope/binding related types out of
context.rs
andtypes.rs
intoscope.rs