Fix incorrect doc in shebang-not-executable (EXE001) and add git+windows solution to executable bit
#15208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ows solution to executable bit
|
dhruvmanila
approved these changes
Dec 31, 2024
crates/ruff_linter/src/rules/flake8_executable/rules/shebang_not_executable.rs
Outdated
Show resolved
Hide resolved
crates/ruff_linter/src/rules/flake8_executable/rules/shebang_not_executable.rs
Outdated
Show resolved
Hide resolved
crates/ruff_linter/src/rules/flake8_executable/rules/shebang_missing_executable_file.rs
Outdated
Show resolved
Hide resolved
dhruvmanila
reviewed
Dec 31, 2024
crates/ruff_linter/src/rules/flake8_executable/rules/shebang_not_executable.rs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I noticed that the solution mentioned in shebang-not-executable (EXE001) was incorrect and likely copy-pasted from shebang-missing-executable-file (EXE002)
It was telling users to remove the executable bit from a non-executable file. Which does nothing.
I also noticed locally that:
chmodwouldn't cause any file change to be noticed by git (EXEwas also passing locally) under WSLSo I added a solution using git update-index --chmod
Test Plan
No test plan, doc changes only.
As for running the chmod commands: python/typeshed#13346