Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fastapi] Update FAST002 to check keyword-only arguments #15119

Merged
merged 1 commit into from
Dec 23, 2024
Merged

[fastapi] Update FAST002 to check keyword-only arguments #15119

merged 1 commit into from
Dec 23, 2024

Conversation

harupy
Copy link
Contributor

@harupy harupy commented Dec 23, 2024

Summary

Close #15117. Update FAST002 to check keyword-only arguments.

Test Plan

New test case

@github-actions GitHub Actions
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@MichaReiser MichaReiser added rule Implementing or modifying a lint rule preview Related to preview mode features labels Dec 23, 2024
dhruvmanila
dhruvmanila approved these changes Dec 23, 2024
View reviewed changes
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@dhruvmanila dhruvmanila merged commit 8440f3e into astral-sh:main Dec 23, 2024
21 checks passed
@harupy harupy deleted the FAST002-keyword-only branch December 23, 2024 11:42
@BrewTestBot BrewTestBot mentioned this pull request Jan 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvmanila dhruvmanila dhruvmanila approved these changes

Assignees
No one assigned
Labels
preview Related to preview mode features rule Implementing or modifying a lint rule
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FAST002 only checks positional and keyword parameters
3 participants
@harupy @dhruvmanila @MichaReiser