Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[red-knot] Understand other legacy typing aliases #14998

Merged
merged 9 commits into from
Dec 17, 2024
Merged

[red-knot] Understand other legacy typing aliases #14998

merged 9 commits into from
Dec 17, 2024

Conversation

InSyncWithFoo
Copy link
Contributor

Summary

Resolves #14997.

Test Plan

Markdown tests.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 16, 2024 •
edited
Loading

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@MichaReiser MichaReiser added the red-knot Multi-file analysis & type inference label Dec 16, 2024
AlexWaygood
AlexWaygood reviewed Dec 16, 2024
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I think we'll probably have to rewrite a lot of this when we add support for generics, but I suppose there's no harm in improving our understanding of these annotations as best we can in the meantime

crates/red_knot_python_semantic/resources/mdtest/annotations/stdlib_typing_aliases.md Outdated Show resolved Hide resolved
AlexWaygood
AlexWaygood approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

crates/red_knot_python_semantic/resources/mdtest/annotations/stdlib_typing_aliases.md Outdated Show resolved Hide resolved
crates/red_knot_python_semantic/resources/mdtest/annotations/stdlib_typing_aliases.md Outdated Show resolved Hide resolved
crates/red_knot_python_semantic/resources/mdtest/annotations/stdlib_typing_aliases.md Outdated Show resolved Hide resolved
crates/red_knot_python_semantic/resources/mdtest/annotations/stdlib_typing_aliases.md Outdated Show resolved Hide resolved
@AlexWaygood AlexWaygood merged commit 7c2e7cf into astral-sh:main Dec 17, 2024
21 checks passed
@InSyncWithFoo InSyncWithFoo deleted the rk-typing-aliases branch December 17, 2024 09:38
dcreager added a commit that referenced this pull request Dec 17, 2024
@dcreager
Merge branch 'main' into dcreager/relative-nested-imports
b41099e 
* main:
  [red-knot] Explicitly test diagnostics are emitted for unresolvable submodule imports (#15035)
  Fix stale File status in tests (#15030)
  [red-knot] Basic support for other legacy `typing` aliases (#14998)
  feat(AIR302): extend the following rules (#15015)
  [`perflint`] Simplify finding the loop target in `PERF401` (#15025)
  [red-knot] Avoid undeclared path when raising conflicting declarations (#14958)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@carljm carljm Awaiting requested review from carljm carljm is a code owner

@MichaReiser MichaReiser Awaiting requested review from MichaReiser MichaReiser is a code owner

@sharkdp sharkdp Awaiting requested review from sharkdp sharkdp is a code owner

Assignees
No one assigned
Labels
red-knot Multi-file analysis & type inference
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[red-knot] Understand other legacy typing aliases
3 participants
@InSyncWithFoo @AlexWaygood @MichaReiser