[red-knot] Fix bugs relating to assignability of dynamic type[] types
#14972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexWaygood
requested review from
carljm,
MichaReiser and
sharkdp
as code owners
AlexWaygood
commented
Dec 14, 2024
There was a problem hiding this comment.
I renamed this file from any.md to dynamic.md since it now contains tests for type[Unknown] as well as type[Any]. They're not different enough to justify a separate test file for type[Unknown], I don't think.
AlexWaygood
commented
Dec 14, 2024
AlexWaygood
force-pushed
the
alex/type-unknown-assignability
branch
from
f5c8cec to
ccb6abf
Compare
|
carljm
approved these changes
Dec 14, 2024
crates/red_knot_python_semantic/resources/mdtest/type_of/dynamic.md
Outdated
Show resolved
Hide resolved
crates/red_knot_python_semantic/resources/mdtest/type_of/dynamic.md
Outdated
Show resolved
Hide resolved
dcreager
added a commit
that referenced
this pull request
Dec 16, 2024
* main: (25 commits) [`pydocstyle`] Skip leading whitespace for `D403` (#14963) Update pre-commit dependencies (#15008) Check diagnostic refresh support from client capability (#15014) Update Rust crate colored to v2.2.0 (#15010) Update dependency monaco-editor to v0.52.2 (#15006) Update Rust crate thiserror to v2.0.7 (#15005) Update Rust crate serde to v1.0.216 (#15004) Update Rust crate libc to v0.2.168 (#15003) Update Rust crate fern to v0.7.1 (#15002) Update Rust crate chrono to v0.4.39 (#15001) Update Rust crate bstr to v1.11.1 (#15000) Update NPM Development dependencies (#14999) Update dependency ruff to v0.8.3 (#15007) Pin mdformat plugins in pre-commit (#14992) Use stripping block (`|-`) for page descriptions (#14980) [`perflint`] Fix panic in `perf401` (#14971) Improve the documentation of E201/E202 (#14983) [ruff_python_ast] Add name and default functions to TypeParam. (#14964) [red-knot] Emit an error if a bare `Annotated` or `Literal` is used in a type expression (#14973) [red-knot] Fix bugs relating to assignability of dynamic `type[]` types (#14972) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
type[Unknown]andtype[Todo]should be considered assignable to alltype[]types, just liketype[Any]. Currently we do not treat them as such.type[Any]should be considered assignable to instances of subclasses oftype. Currently we only consider it assignable toInstance("builtins.type"), and do not consider it assignable toInstance("abc.ABCMeta")-- butABCMetais a subclass oftype.Test Plan
New unit tests and mdtests added. They fail on
main.