[flake8-bugbear] Offer unsafe autofix for no-explicit-stacklevel (B028)
#14829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crates/ruff_linter/src/rules/flake8_bugbear/rules/no_explicit_stacklevel.rs
Outdated
Show resolved
Hide resolved
| let mut diagnostic = Diagnostic::new(NoExplicitStacklevel, call.func.range()); | ||
|
|
||
| let edit = add_argument( | ||
| "stacklevel=2", |
There was a problem hiding this comment.
I'm super surprised this method doesn't need to know if this is a keyword or positional argument!
There was a problem hiding this comment.
I was also surprised... it seems like it would actually be unsafe to use this method for positional arguments, since it always adds the argument to the end? If that's correct and you'd like me to make a followup PR, let me know - I'd be happy to!
There was a problem hiding this comment.
Yeah feel free to take a look!
charliermarsh
approved these changes
Dec 7, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces an unsafe autofix for no-explicit-stacklevel (B028): we add the
stacklevelargument, set to2.Closes #14805