[red-knot] Import LiteralString/Never from typing_extensions
#14817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`typing.Never` and `typing.LiteralString` are only conditionally exported from `typing` for Python versions 3.11 and later. We run the Markdown tests with the default Python version of 3.9, so here we change the import to `typing_extensions` instead, and add a new test to make sure we'll continue to understand the `typing`-version of these symbols for newer versions. This didn't cause problems so far, as we don't understand `sys.version_info` branches yet.
sharkdp
requested review from
carljm,
MichaReiser and
AlexWaygood
as code owners
AlexWaygood
approved these changes
Dec 6, 2024
sharkdp
commented
Dec 6, 2024
| @@ -57,6 +57,8 @@ class C(LiteralString): ... # error: [invalid-base] | |||
| ### Common operations | |||
|
|
|||
| ```py | |||
| from typing_extensions import LiteralString | |||
There was a problem hiding this comment.
These imports were simply missing. This didn't cause problems so far because of #14099 (thanks @AlexWaygood)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
typing.Neverandtyping.LiteralStringare only conditionally exported fromtypingfor Python versions 3.11 and later. We run the Markdown tests with the default Python version of 3.9, so here we change the import totyping_extensionsinstead, and add a new test to make sure we'll continue to understand thetyping-version of these symbols for newer versions.This didn't cause problems so far, as we don't understand
sys.version_infobranches yet.Test Plan
New Markdown tests to make sure this will continue to work in the future.