Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flake8-pyi] Also remove self and cls's annotation (PYI034) #14801

Merged
merged 6 commits into from
Dec 9, 2024

Conversation

InSyncWithFoo
Copy link
Contributor

Summary

Resolves #14421.

Test Plan

cargo nextest run and cargo insta test.

Copy link
Contributor

github-actions bot commented Dec 6, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@dylwil3 dylwil3 added bug Something isn't working fixes Related to suggested fixes for violations labels Dec 6, 2024
@AlexWaygood AlexWaygood enabled auto-merge (squash) December 9, 2024 14:56
@AlexWaygood AlexWaygood disabled auto-merge December 9, 2024 14:56
@AlexWaygood AlexWaygood merged commit aa6b812 into astral-sh:main Dec 9, 2024
21 checks passed
@InSyncWithFoo InSyncWithFoo deleted the PYI034 branch December 9, 2024 15:13
MichaReiser pushed a commit that referenced this pull request Dec 9, 2024
(Accidentally introduced in #14801.)
dcreager added a commit that referenced this pull request Dec 10, 2024
* main:
  [`airflow`] Add fix to remove deprecated keyword arguments (`AIR302`) (#14887)
  Improve mdtests style (#14884)
  Reference `suppress-dummy-regex-options` in documentation of rules supporting it (#14888)
  [`flake8-bugbear`] `itertools.batched()` without explicit `strict` (`B911`) (#14408)
  [`ruff`] Mark autofix for `RUF052` as always unsafe (#14824)
  [red-knot] Improve type inference for except handlers (#14838)
  More typos found by codespell (#14880)
  [red-knot] move standalone expression_ty to TypeInferenceBuilder::file_expression_ty (#14879)
  [`ruff`] Do not simplify `round()` calls (`RUF046`) (#14832)
  Stop referring to early ruff versions (#14862)
  Fix a typo in `class.rs` (#14877)
  [`flake8-pyi`] Also remove `self` and `cls`'s annotation (`PYI034`) (#14801)
  [`pyupgrade`] Remove unreachable code in `UP015` implementation (#14871)
  [`flake8-bugbear`] Skip `B028` if `warnings.warn` is called with `*args` or `**kwargs` (#14870)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixes Related to suggested fixes for violations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with new PYI034 autofix when first param is annotated
3 participants