Add tests for "keyword as identifier" syntax errors #14754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhruvmanila
force-pushed
the
dhruv/keyword-as-identifier
branch
from
7fee9f8 to
8b158c0
Compare
dhruvmanila
changed the base branch from
dhruv/identifier-parse-result
to
main
|
dhruvmanila
requested review from
carljm,
MichaReiser,
AlexWaygood and
sharkdp
as code owners
MichaReiser
reviewed
Dec 5, 2024
| # error: [invalid-syntax] | ||
| pass | ||
|
|
||
| # TODO: Why is there two diagnostics for the same error? |
dhruvmanila
added a commit
that referenced
this pull request
Dec 5, 2024
…14788) ## Summary Ref: #14754 (comment) ## Test Plan Remove the TODO comment and update the mdtest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is related to #13778, more specifically #13778 (comment).
This PR adds various test cases where a keyword is being where an identifier is expected. The tests are to make sure that red knot doesn't panic, raises the syntax error and the identifier is added to the symbol table. The final part allows editor related features like renaming the symbol.