Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[flake8-pyi, ruff] Fix traversal of nested literals and unions (PYI016, PYI051, PYI055, PYI062, RUF041) #14641

Merged
merged 4 commits into from
Nov 28, 2024
Merged

[flake8-pyi, ruff] Fix traversal of nested literals and unions (PYI016, PYI051, PYI055, PYI062, RUF041) #14641

merged 4 commits into from
Nov 28, 2024

Conversation

sbrugman
Copy link
Contributor

@sbrugman sbrugman commented Nov 27, 2024 •
edited
Loading

Summary

In previous work on PYI rules we found that the current traversal misses nested literals and unions.
These are rare but valid. As mentioned before, correctly handling these cases might be relevant for auto-generated stubs.

Test Plan

Added test cases in an earlier PR. Snapshots are updated and show nested literals and unions are now handled as expected.
No ecosystem changes.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 27, 2024 •
edited
Loading

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

AlexWaygood
AlexWaygood reviewed Nov 27, 2024
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!! Most of the snapshot changes look great, but I spotted a couple of issues and I'm not sure I fully understand the changes you're making to the methods on SemanticModel

...src/rules/flake8_pyi/snapshots/ruff_linter__rules__flake8_pyi__tests__PYI055_PYI055.pyi.snap Show resolved Hide resolved
...src/rules/flake8_pyi/snapshots/ruff_linter__rules__flake8_pyi__tests__PYI055_PYI055.pyi.snap Show resolved Hide resolved
crates/ruff_python_semantic/src/model.rs Outdated Show resolved Hide resolved
@AlexWaygood AlexWaygood added the linter Related to the linter label Nov 27, 2024
@sbrugman
Copy link
Contributor Author

Thanks Alex! I'll pick this up tomorrow.

@sbrugman sbrugman force-pushed the nested-literals-unions branch from 5899085 to b31732f Compare November 28, 2024 17:55
@sbrugman sbrugman force-pushed the nested-literals-unions branch from b31732f to e3b0f5f Compare November 28, 2024 17:55
AlexWaygood
AlexWaygood approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@AlexWaygood AlexWaygood added the bug Something isn't working label Nov 28, 2024
@AlexWaygood AlexWaygood changed the title Fix traversal of nested literals and unions [flake8-pyi, ruff] Fix traversal of nested literals and unions (PYI016, PYI051, PYI055, PYI062, RUF041) Nov 28, 2024
@AlexWaygood AlexWaygood merged commit dc29f52 into astral-sh:main Nov 28, 2024
21 checks passed
@sbrugman sbrugman deleted the nested-literals-unions branch November 28, 2024 18:08
@sbrugman sbrugman mentioned this pull request Nov 28, 2024
Merged
@BrewTestBot BrewTestBot mentioned this pull request Nov 29, 2024
Merged
@MichaReiser MichaReiser mentioned this pull request Dec 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees
No one assigned
Labels
bug Something isn't working linter Related to the linter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbrugman @AlexWaygood