New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pyupgrade: converts `universal_newlines` to `text` in `subprocess.run` #1403

Merged

charliermarsh merged 9 commits into astral-sh:main from colin99d:un_nl_to_txt

Dec 27, 2022

Contributor

colin99d commented Dec 27, 2022 •

edited

Loading

A part of #827.

colin99d and others added 3 commits

December 27, 2022 08:37


          Got UP021 working

eb754a0


          Got misc stuff working

29a047d


          Merge branch 'main' into un_nl_to_txt

7fe18ce

squiddy reviewed

View reviewed changes

src/pyupgrade/plugins/replace_universal_newlines.rs Outdated Show resolved Hide resolved

colin99d added 3 commits

December 27, 2022 08:53


          Switched to find_keyword function

08b6f1f


          Merge branch 'un_nl_to_txt' of https://github.com/colin99d/ruff into …

defef6f

…un_nl_to_txt


          Updated Readme

a87978b

Contributor Author

colin99d commented Dec 27, 2022

This file is outdated. You may have to rerun 'cargo dev generate-options' and/or 'cargo dev generate-rules-table'.
@charliermarsh if we have all these commands that just need to be run every time, why not add it do the CI so that contributors don't need to worry about it?

Member

charliermarsh commented Dec 27, 2022

@colin99d - I'm hoping to make it a build step so that it all gets built automatically.

Member

charliermarsh commented Dec 27, 2022

Eh, maybe some of these are inappropriate for a cargo build script.

colin99d and others added 3 commits

December 27, 2022 09:29


          Updated check_gen

2e35002


          Merge branch 'main' into un_nl_to_txt

54a4aec


          Simplify end location detection

332862b

charliermarsh merged commit c590351 into astral-sh:main

charliermarsh reviewed

View reviewed changes

src/pyupgrade/plugins/replace_universal_newlines.rs Show resolved Hide resolved

colin99d deleted the un_nl_to_txt branch

December 27, 2022 23:30

renovate bot referenced this pull request in ixm-one/pytest-cmake-presets


          ⬆️ Update dependency ruff to ^0.0.196 (#7)

84781d8

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [ruff](https://togithub.com/charliermarsh/ruff) | `^0.0.195` ->
`^0.0.196` |
[![age](https://badges.renovateapi.com/packages/pypi/ruff/0.0.196/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/pypi/ruff/0.0.196/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/pypi/ruff/0.0.196/compatibility-slim/0.0.195)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/pypi/ruff/0.0.196/confidence-slim/0.0.195)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>charliermarsh/ruff</summary>

###
[`v0.0.196`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.196)

[Compare
Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.195...v0.0.196)

#### What's Changed

- Implement pyupgrade check for io.open alias by
[@&#8203;squiddy](https://togithub.com/squiddy) in
[https://github.com/charliermarsh/ruff/pull/1399](https://togithub.com/charliermarsh/ruff/pull/1399)
- Tweak secret detection for playground releases by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[https://github.com/charliermarsh/ruff/pull/1402](https://togithub.com/charliermarsh/ruff/pull/1402)
- Support isort's force-single-line option by
[@&#8203;squiddy](https://togithub.com/squiddy) in
[https://github.com/charliermarsh/ruff/pull/1366](https://togithub.com/charliermarsh/ruff/pull/1366)
- Replace `make_tokenize` with `make_tokenizer_located` by
[@&#8203;harupy](https://togithub.com/harupy) in
[https://github.com/charliermarsh/ruff/pull/1405](https://togithub.com/charliermarsh/ruff/pull/1405)
- Add cargo +nightly dev generate-all by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[https://github.com/charliermarsh/ruff/pull/1404](https://togithub.com/charliermarsh/ruff/pull/1404)
- Allow specification of explicit docstring convention by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[https://github.com/charliermarsh/ruff/pull/1408](https://togithub.com/charliermarsh/ruff/pull/1408)
- Pyupgrade: converts `universal_newlines` to `text` in `subprocess.run`
by [@&#8203;colin99d](https://togithub.com/colin99d) in
[https://github.com/charliermarsh/ruff/pull/1403](https://togithub.com/charliermarsh/ruff/pull/1403)
- Fix invalid reference to ruff_options.rs by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[https://github.com/charliermarsh/ruff/pull/1409](https://togithub.com/charliermarsh/ruff/pull/1409)

**Full Changelog**:
astral-sh/ruff@v0.0.195...v0.0.196

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/ixm-one/pytest-cmake-presets).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC43My4zIiwidXBkYXRlZEluVmVyIjoiMzQuNzMuMyJ9-->

Signed-off-by: Renovate Bot <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet