Refactor: Remove StringPart
and AnyStringPart
in favor of StringLikePart
#13772
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I don't think having both types still makes sense.
The way I remember it is that we had
StringPart
first, a generic representation of any string part.We later introduced
AnyStringPart
without realizing that we now have two generic representations of a string part. We then also addedStringLike
when we needed a similar construct in the linter. And there were three representations :)This PR removes
StringPart
andAnyStringPart
and replaces them withStringLikePart
, to only have one generic string part representation.Split out from #13663
Test Plan
cargo test