Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Add CrowdCent's numerblox to Ruff users. #13569

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

CarloLepelaars
Copy link

@CarloLepelaars CarloLepelaars commented Sep 30, 2024

Hi, our open source project NumerBlox migrated to uv and ruff. Would appreciate the project being included in the list of Ruff users.

Summary

Add NumerBlox to Ruff users in README.md.

Add CrowdCent to Ruff users
@CarloLepelaars CarloLepelaars changed the title [DOCS] Add CrowdCent numerblox to Ruff users. [DOCS] Add CrowdCent's numerblox to Ruff users. Sep 30, 2024
Add NumerBlox to valid words
Ignore NumerBlox getting flagged as typo
Copy link
Member

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you take a look at the formatting (the pre-commit test is failing)

@CarloLepelaars
Copy link
Author

Could you take a look at the formatting (the pre-commit test is failing)

Hey @MichaReiser, thank you for the reply! The pre-commit thinks NumerBlox is a typo, but it is not.

I tried:

  1. Adding NumerBlox to _typos.toml
  2. Adding inline comment <!-- typos: ignore --> to the README line.

Though these don't work. Do you have an idea on how to make sure the pre-commit doesn't classify NumerBlox as a typo? This is the only obstacle.

@MichaReiser
Copy link
Member

Adding it to `types.toml should do the job

@CarloLepelaars
Copy link
Author

I've added NumerBlox to _typos.toml, but unfortunately the pre-commit still fails. Is there something I'm missing?

@calumy
Copy link
Contributor

calumy commented Oct 7, 2024

I've added NumerBlox to _typos.toml, but unfortunately the pre-commit still fails. Is there something I'm missing?

Could you try just Numer rather than NumerBlox as this is the bit that typos appears to be trying to correct.

@CarloLepelaars
Copy link
Author

Could you try just Numer rather than NumerBlox as this is the bit that typos appears to be trying to correct.

Thank you for the suggestion @calumy! All CI is passing now!

@MichaReiser MichaReiser self-requested a review October 8, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants