-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic concurrent checking #13049
Merged
Merged
Basic concurrent checking #13049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #13049 will not alter performanceComparing Summary
|
|
MichaReiser
force-pushed
the
concurrent=checking
branch
from
August 23, 2024 07:21
c11b4e6
to
f0b97c1
Compare
MichaReiser
changed the title
A very basic prototype for concurrent checking
Basic concurrent checking
Aug 23, 2024
MichaReiser
force-pushed
the
concurrent=checking
branch
from
August 23, 2024 07:21
f0b97c1
to
2549d5b
Compare
MichaReiser
force-pushed
the
concurrent=checking
branch
from
August 23, 2024 07:59
5401274
to
fc359e9
Compare
MichaReiser
force-pushed
the
concurrent=checking
branch
from
August 23, 2024 08:16
fc359e9
to
acbed7c
Compare
carljm
approved these changes
Aug 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
AlexWaygood
added a commit
that referenced
this pull request
Aug 28, 2024
Followup to #13049. We check files concurrently now; to get readable logs, you probably want to switch that off
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes
workspace.check
to check the files concurrently.This PR doesn't explore more advanced scheduling. For example, we could try to not only schedule the workspace files
but also the dependencies of those files. This would give us better performance where a project has few first-party modules but depends on many third-party modules.
The main downside of concurrent checking is that the logs become harder to read, especially when using
-vvv
because the output of different threads is intertwined. I don't have a good solution for this yet other than usingRAYON_NUM_THREADS=1
to explicitly fall-back to a single thread.Test Plan
Checking black goes down from 108ms to 34ms (12 cores)
Main
Concurrent