[flake8-pyi] Skip Annotated and Literal for string-or-bytes-too-long (PYI053)
#13020
Conversation
|
| /// ```python | ||
| /// def f(x: Annotated[int, "A"]): ... | ||
| /// ``` | ||
| const TYPING_ANNOTATED_PEP593 = 1<<27; |
There was a problem hiding this comment.
oof... but I have been trying to think of a better name for 10 minutes and I've got nothing 😆
There was a problem hiding this comment.
Seems like a reasonable name given other variants although I leave this up to you to decide, maybe you come up with a better name in the morning ;)
There was a problem hiding this comment.
Aside, it would be useful to provide a link to PEP 593 in the documentation above @dylwil3
|
I know this has been waiting on me for a little bit -- have to call it for the day now, but will try to land it tomorrow! |
No worries at all! |
|
@AlexWaygood if it was possible to meekly whisper a nudge in the form of a notification, I would, but github allows for only one volume. Let me know if there's anything else you'd like me to do on this one 😄 |
|
@dylwil3 - Just a heads up (in case it wasn't mentioned elsewhere) that Alex is on vacation this week so may be a few more days before he gets to it. (It's totally fine that you nudged and in fact your nudge was very gracious!) |
PYI053 now skips strings which appear inside
Literal[...]orAnnotated[...].This is a modification of #13002, which skipped any type annotation for this rule. So, on the one hand, this PR allows the check to proceed in some cases that the prior PR skipped (e.g. return type annotations wrapped - unnecessarily, for a stub file - in quotes), and, on the other hand, this PR skips certain strings that the prior PR did not (e.g. type alias assignments to a
LiteralorAnnotatedtype.)In order to implement this change, the PR adds a new semantic flag for PEP593 annotations (i.e.
typing.Annotated[...])Closes #12995 (hopefully!)