Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup description of default values for fixture-parentheses and mark-parentheses #12904

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

AlexWaygood
Copy link
Member

I noticed while creating a PR to update the schemastore entry for Ruff that there was still some language here that implied that these defaulted to true; but they default to false on ruff 0.6+. #12838 changed some but not all the language here.

Copy link

codspeed-hq bot commented Aug 15, 2024

CodSpeed Performance Report

Merging #12904 will improve performances by 10.63%

Comparing pt-default (408301a) with main (b9da316)

Summary

⚡ 1 improvements
✅ 31 untouched benchmarks

Benchmarks breakdown

Benchmark main pt-default Change
linter/all-with-preview-rules[numpy/globals.py] 911.3 µs 823.7 µs +10.63%

Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Copy link
Member

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AlexWaygood AlexWaygood merged commit 6ed06af into main Aug 15, 2024
20 checks passed
@AlexWaygood AlexWaygood deleted the pt-default branch August 15, 2024 14:20
@AlexWaygood AlexWaygood added documentation Improvements or additions to documentation configuration Related to settings and configuration labels Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
configuration Related to settings and configuration documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants